Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(355)

Issue 2245533004: Reapply fast-URI patch. (Closed)

Created:
4 years, 4 months ago by Lasse Reichstein Nielsen
Modified:
4 years, 4 months ago
Reviewers:
siva
CC:
reviews_dartlang.org, vm-dev_dartlang.org
Base URL:
https://github.com/dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3373 lines, -2020 lines) Patch
M CHANGELOG.md View 1 chunk +3 lines, -0 lines 0 comments Download
M pkg/analyzer/lib/src/util/fast_uri.dart View 1 chunk +1 line, -17 lines 0 comments Download
M runtime/lib/uri_patch.dart View 1 chunk +9 lines, -7 lines 0 comments Download
M sdk/lib/_internal/js_runtime/lib/core_patch.dart View 1 chunk +5 lines, -3 lines 0 comments Download
M sdk/lib/core/uri.dart View 21 chunks +3091 lines, -1987 lines 0 comments Download
M tests/compiler/dart2js/compiler_helper.dart View 1 chunk +1 line, -1 line 0 comments Download
M tests/compiler/dart2js/mirrors_used_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M tests/corelib/data_uri_test.dart View 2 chunks +15 lines, -0 lines 0 comments Download
M tests/corelib/uri_test.dart View 7 chunks +247 lines, -4 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
Lasse Reichstein Nielsen
@asiva With this CL, I get apparent heap corruption in debug mode in a few ...
4 years, 4 months ago (2016-08-12 12:03:21 UTC) #2
siva
On 2016/08/12 12:03:21, Lasse Reichstein Nielsen wrote: > @asiva With this CL, I get apparent ...
4 years, 4 months ago (2016-08-15 15:59:24 UTC) #3
siva
On 2016/08/15 15:59:24, siva wrote: > On 2016/08/12 12:03:21, Lasse Reichstein Nielsen wrote: > > ...
4 years, 4 months ago (2016-08-16 20:09:14 UTC) #4
Lasse Reichstein Nielsen
> I have landed https://codereview.chromium.org/2255553002 which fixes the heap > corruption exhibited when your CL ...
4 years, 4 months ago (2016-08-16 20:16:21 UTC) #5
Lasse Reichstein Nielsen
4 years, 4 months ago (2016-08-17 08:54:28 UTC) #7
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
afbbbb97cfcd86a64d0ba5dcfe1ab758954adaf4 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698