Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(242)

Issue 2245533002: Don't use library tag for private name prefixes (Closed)

Created:
4 years, 4 months ago by sra1
Modified:
4 years, 4 months ago
CC:
reviews_dartlang.org
Base URL:
https://github.com/dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Don't use library tag for private name prefixes Use only the Uri. R=sigmund@google.com Committed: https://github.com/dart-lang/sdk/commit/b5efb1c0c16b7f867b7f3fb375f2087e2696f019

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+52 lines, -43 lines) Patch
M pkg/compiler/lib/src/js_backend/namer.dart View 1 chunk +52 lines, -43 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
sra1
4 years, 4 months ago (2016-08-12 02:26:50 UTC) #2
Siggi Cherem (dart-lang)
lgtm!
4 years, 4 months ago (2016-08-12 16:08:11 UTC) #3
sra1
4 years, 4 months ago (2016-08-12 17:21:10 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
b5efb1c0c16b7f867b7f3fb375f2087e2696f019 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698