cc : Cache trasnforms to target even when target is a descendant

cc : Cache transforms to target even when target is a descendant

BUG=622372
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel

Committed: https://crrev.com/778cb271a6aa17d43966ae76e1f33579a7d600a8
Cr-Commit-Position: refs/heads/master@{#412007}

[jaydasika, 2016-08-11 21:52:40]

Description was changed from

==========
cc : Cache trasnforms to target even when target is a descendant

BUG=
==========

to

==========
cc : Cache trasnforms to target even when target is a descendant

BUG=
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel
==========

[jaydasika, 2016-08-11 22:05:26]

Description was changed from

==========
cc : Cache trasnforms to target even when target is a descendant

BUG=
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel
==========

to

==========
cc : Cache trasnforms to target even when target is a descendant

BUG=622372
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel
==========

[jaydasika, 2016-08-11 22:05:51]

jaydasika@chromium.org changed reviewers:
+ ajuma@chromium.org

[jaydasika, 2016-08-11 22:05:51]

PTAL

https://codereview.chromium.org/2245463002/diff/1/cc/trees/draw_property_util...
File cc/trees/draw_property_utils.cc (right):

https://codereview.chromium.org/2245463002/diff/1/cc/trees/draw_property_util...
cc/trees/draw_property_utils.cc:134: target_node_id,
clip_node->target_effect_id, &clip_to_target)) {
In this case, target_effect_node->id > clip_node->target_effect_id. So, calling
from target will make it avoid that path where we have to walk from source to
destination.

[jaydasika, 2016-08-11 22:06:04]

The CQ bit was checked by jaydasika@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-08-11 22:06:58]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[ajuma, 2016-08-11 23:17:56]

https://codereview.chromium.org/2245463002/diff/1/cc/trees/property_tree.cc
File cc/trees/property_tree.cc (right):

https://codereview.chromium.org/2245463002/diff/1/cc/trees/property_tree.cc#n...
cc/trees/property_tree.cc:2006:
target_space_transform.PreconcatTransform(combined_transform);
I'm probably missing something, but doesn't this line turn
target_space_transform into the identity?

[commit-bot: I haz the power, 2016-08-12 00:30:13]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-12 00:30:14]

Dry run: Try jobs failed on following builders:
  mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[jaydasika, 2016-08-12 00:37:21]

https://codereview.chromium.org/2245463002/diff/1/cc/trees/property_tree.cc
File cc/trees/property_tree.cc (right):

https://codereview.chromium.org/2245463002/diff/1/cc/trees/property_tree.cc#n...
cc/trees/property_tree.cc:2006:
target_space_transform.PreconcatTransform(combined_transform);
On 2016/08/11 23:17:56, ajuma (OOO till Aug. 15) wrote:
> I'm probably missing something, but doesn't this line turn
> target_space_transform into the identity?

Oops, my bad. I din't catch it as there are no unit tests that are hittihg this
path. Changed one of the tests to hit this path.

[jaydasika, 2016-08-12 00:37:53]

The CQ bit was checked by jaydasika@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-08-12 00:38:37]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-12 01:52:54]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-12 01:52:54]

Dry run: This issue passed the CQ dry run.

[ajuma, 2016-08-15 14:46:14]

Thanks, lgtm

Please fix the typo in the description ("transforms") before landing.

[jaydasika, 2016-08-15 17:27:38]

Description was changed from

==========
cc : Cache trasnforms to target even when target is a descendant

BUG=622372
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel
==========

to

==========
cc : Cache transforms to target even when target is a descendant

BUG=622372
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel
==========

[jaydasika, 2016-08-15 17:27:55]

The CQ bit was checked by jaydasika@chromium.org

[commit-bot: I haz the power, 2016-08-15 17:28:30]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-15 19:01:12]

Description was changed from

==========
cc : Cache transforms to target even when target is a descendant

BUG=622372
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel
==========

to

==========
cc : Cache transforms to target even when target is a descendant

BUG=622372
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel
==========

[commit-bot: I haz the power, 2016-08-15 19:01:13]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2016-08-15 19:05:59]

Description was changed from

==========
cc : Cache transforms to target even when target is a descendant

BUG=622372
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel
==========

to

==========
cc : Cache transforms to target even when target is a descendant

BUG=622372
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel

Committed: https://crrev.com/778cb271a6aa17d43966ae76e1f33579a7d600a8
Cr-Commit-Position: refs/heads/master@{#412007}
==========

[commit-bot: I haz the power, 2016-08-15 19:06:01]

Patchset 3 (id:??) landed as
https://crrev.com/778cb271a6aa17d43966ae76e1f33579a7d600a8
Cr-Commit-Position: refs/heads/master@{#412007}