Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(13)

Issue 2245463002: cc : Cache trasnforms to target even when target is a descendant (Closed)

Created:
4 years, 4 months ago by jaydasika
Modified:
4 years, 4 months ago
Reviewers:
ajuma
CC:
chromium-reviews, cc-bugs_chromium.org, weiliangc, sunxd
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

cc : Cache transforms to target even when target is a descendant BUG=622372 CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel Committed: https://crrev.com/778cb271a6aa17d43966ae76e1f33579a7d600a8 Cr-Commit-Position: refs/heads/master@{#412007}

Patch Set 1 #

Total comments: 3

Patch Set 2 : . #

Patch Set 3 : test #

Unified diffs Side-by-side diffs Delta from patch set Stats (+69 lines, -31 lines) Patch
M cc/trees/draw_property_utils.cc View 1 chunk +2 lines, -3 lines 0 comments Download
M cc/trees/layer_tree_host_common_unittest.cc View 1 2 1 chunk +4 lines, -0 lines 0 comments Download
M cc/trees/property_tree.cc View 1 2 5 chunks +63 lines, -28 lines 0 comments Download

Messages

Total messages: 22 (15 generated)
jaydasika
PTAL https://codereview.chromium.org/2245463002/diff/1/cc/trees/draw_property_utils.cc File cc/trees/draw_property_utils.cc (right): https://codereview.chromium.org/2245463002/diff/1/cc/trees/draw_property_utils.cc#newcode134 cc/trees/draw_property_utils.cc:134: target_node_id, clip_node->target_effect_id, &clip_to_target)) { In this case, target_effect_node->id ...
4 years, 4 months ago (2016-08-11 22:05:51 UTC) #4
ajuma
https://codereview.chromium.org/2245463002/diff/1/cc/trees/property_tree.cc File cc/trees/property_tree.cc (right): https://codereview.chromium.org/2245463002/diff/1/cc/trees/property_tree.cc#newcode2006 cc/trees/property_tree.cc:2006: target_space_transform.PreconcatTransform(combined_transform); I'm probably missing something, but doesn't this line ...
4 years, 4 months ago (2016-08-11 23:17:56 UTC) #7
jaydasika
https://codereview.chromium.org/2245463002/diff/1/cc/trees/property_tree.cc File cc/trees/property_tree.cc (right): https://codereview.chromium.org/2245463002/diff/1/cc/trees/property_tree.cc#newcode2006 cc/trees/property_tree.cc:2006: target_space_transform.PreconcatTransform(combined_transform); On 2016/08/11 23:17:56, ajuma (OOO till Aug. 15) ...
4 years, 4 months ago (2016-08-12 00:37:21 UTC) #10
ajuma
Thanks, lgtm Please fix the typo in the description ("transforms") before landing.
4 years, 4 months ago (2016-08-15 14:46:14 UTC) #15
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2245463002/40001
4 years, 4 months ago (2016-08-15 17:28:30 UTC) #18
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 4 months ago (2016-08-15 19:01:13 UTC) #20
commit-bot: I haz the power
4 years, 4 months ago (2016-08-15 19:06:01 UTC) #22
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/778cb271a6aa17d43966ae76e1f33579a7d600a8
Cr-Commit-Position: refs/heads/master@{#412007}

Powered by Google App Engine
This is Rietveld 408576698