Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(99)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2245423002: WebRTC: Don't specify All compile target (Closed)

Created:
4 years, 4 months ago by kjellander_chromium
Modified:
4 years, 4 months ago
CC:
chromium-reviews, infra-reviews+build_chromium.org, kjellander-cc_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/tools/build.git@master
Target Ref:
refs/heads/master
Project:
build
Visibility:
Public.

Description

WebRTC: Don't specify All compile target Our developers normally build the default target which implicitly becomes 'All' for GYP and "all generated targets" for GN. This should ease the flipping of bots from GYP to GN. BUG=webrtc:5949 Committed: https://chromium.googlesource.com/chromium/tools/build/+/d3dba1d2122e52ccb3de81c84181169c997529fe

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+70 lines, -139 lines) Patch
M scripts/slave/recipe_modules/webrtc/chromium_config.py View 1 chunk +1 line, -1 line 0 comments Download
M scripts/slave/recipes/webrtc/standalone.expected/client_webrtc_fyi_linux64_gcc.json View 1 chunk +1 line, -2 lines 0 comments Download
M scripts/slave/recipes/webrtc/standalone.expected/client_webrtc_fyi_linux64_release__swarming_.json View 1 chunk +1 line, -2 lines 0 comments Download
M scripts/slave/recipes/webrtc/standalone.expected/client_webrtc_fyi_mac64_release__swarming_.json View 1 chunk +1 line, -2 lines 0 comments Download
M scripts/slave/recipes/webrtc/standalone.expected/client_webrtc_fyi_win32_release__swarming_.json View 1 chunk +1 line, -2 lines 0 comments Download
M scripts/slave/recipes/webrtc/standalone.expected/client_webrtc_linux32_arm.json View 1 chunk +1 line, -2 lines 0 comments Download
M scripts/slave/recipes/webrtc/standalone.expected/client_webrtc_linux64_debug.json View 1 chunk +1 line, -2 lines 0 comments Download
M scripts/slave/recipes/webrtc/standalone.expected/client_webrtc_linux64_debug_failing_test.json View 1 chunk +1 line, -2 lines 0 comments Download
M scripts/slave/recipes/webrtc/standalone.expected/client_webrtc_linux64_debug_forced.json View 1 chunk +1 line, -2 lines 0 comments Download
M scripts/slave/recipes/webrtc/standalone.expected/client_webrtc_linux64_release.json View 1 chunk +1 line, -2 lines 0 comments Download
M scripts/slave/recipes/webrtc/standalone.expected/client_webrtc_linux64_release__large_tests_.json View 1 chunk +1 line, -2 lines 0 comments Download
M scripts/slave/recipes/webrtc/standalone.expected/client_webrtc_linux_asan.json View 1 chunk +1 line, -2 lines 0 comments Download
M scripts/slave/recipes/webrtc/standalone.expected/client_webrtc_linux_memcheck.json View 1 chunk +1 line, -2 lines 0 comments Download
M scripts/slave/recipes/webrtc/standalone.expected/client_webrtc_linux_msan.json View 1 chunk +1 line, -2 lines 0 comments Download
M scripts/slave/recipes/webrtc/standalone.expected/client_webrtc_linux_tsan_v2.json View 1 chunk +1 line, -2 lines 0 comments Download
M scripts/slave/recipes/webrtc/standalone.expected/client_webrtc_linux_ubsan.json View 1 chunk +1 line, -2 lines 0 comments Download
M scripts/slave/recipes/webrtc/standalone.expected/client_webrtc_linux_ubsan_vptr.json View 1 chunk +1 line, -2 lines 0 comments Download
M scripts/slave/recipes/webrtc/standalone.expected/client_webrtc_mac64_debug.json View 1 chunk +1 line, -2 lines 0 comments Download
M scripts/slave/recipes/webrtc/standalone.expected/client_webrtc_mac64_release.json View 1 chunk +1 line, -2 lines 0 comments Download
M scripts/slave/recipes/webrtc/standalone.expected/client_webrtc_mac64_release__large_tests_.json View 1 chunk +1 line, -2 lines 0 comments Download
M scripts/slave/recipes/webrtc/standalone.expected/client_webrtc_mac_asan.json View 1 chunk +1 line, -2 lines 0 comments Download
M scripts/slave/recipes/webrtc/standalone.expected/client_webrtc_win32_debug.json View 1 chunk +1 line, -2 lines 0 comments Download
M scripts/slave/recipes/webrtc/standalone.expected/client_webrtc_win32_debug__clang_.json View 1 chunk +1 line, -2 lines 0 comments Download
M scripts/slave/recipes/webrtc/standalone.expected/client_webrtc_win32_release.json View 1 chunk +1 line, -2 lines 0 comments Download
M scripts/slave/recipes/webrtc/standalone.expected/client_webrtc_win32_release__clang_.json View 1 chunk +1 line, -2 lines 0 comments Download
M scripts/slave/recipes/webrtc/standalone.expected/client_webrtc_win32_release__large_tests_.json View 1 chunk +1 line, -2 lines 0 comments Download
M scripts/slave/recipes/webrtc/standalone.expected/client_webrtc_win64_debug.json View 1 chunk +1 line, -2 lines 0 comments Download
M scripts/slave/recipes/webrtc/standalone.expected/client_webrtc_win64_debug__clang_.json View 1 chunk +1 line, -2 lines 0 comments Download
M scripts/slave/recipes/webrtc/standalone.expected/client_webrtc_win64_release.json View 1 chunk +1 line, -2 lines 0 comments Download
M scripts/slave/recipes/webrtc/standalone.expected/client_webrtc_win64_release__clang_.json View 1 chunk +1 line, -2 lines 0 comments Download
M scripts/slave/recipes/webrtc/standalone.expected/client_webrtc_win_drmemory_full.json View 1 chunk +1 line, -2 lines 0 comments Download
M scripts/slave/recipes/webrtc/standalone.expected/client_webrtc_win_drmemory_light.json View 1 chunk +1 line, -2 lines 0 comments Download
M scripts/slave/recipes/webrtc/standalone.expected/client_webrtc_win_syzyasan.json View 1 chunk +1 line, -2 lines 0 comments Download
M scripts/slave/recipes/webrtc/standalone.expected/tryserver_webrtc_linux_arm.json View 1 chunk +1 line, -2 lines 0 comments Download
M scripts/slave/recipes/webrtc/standalone.expected/tryserver_webrtc_linux_asan.json View 1 chunk +1 line, -2 lines 0 comments Download
M scripts/slave/recipes/webrtc/standalone.expected/tryserver_webrtc_linux_baremetal.json View 1 chunk +1 line, -2 lines 0 comments Download
M scripts/slave/recipes/webrtc/standalone.expected/tryserver_webrtc_linux_compile_dbg.json View 1 chunk +1 line, -2 lines 0 comments Download
M scripts/slave/recipes/webrtc/standalone.expected/tryserver_webrtc_linux_compile_rel.json View 1 chunk +1 line, -2 lines 0 comments Download
M scripts/slave/recipes/webrtc/standalone.expected/tryserver_webrtc_linux_dbg.json View 1 chunk +1 line, -2 lines 0 comments Download
M scripts/slave/recipes/webrtc/standalone.expected/tryserver_webrtc_linux_memcheck.json View 1 chunk +1 line, -2 lines 0 comments Download
M scripts/slave/recipes/webrtc/standalone.expected/tryserver_webrtc_linux_msan.json View 1 chunk +1 line, -2 lines 0 comments Download
M scripts/slave/recipes/webrtc/standalone.expected/tryserver_webrtc_linux_rel.json View 1 chunk +1 line, -2 lines 0 comments Download
M scripts/slave/recipes/webrtc/standalone.expected/tryserver_webrtc_linux_swarming.json View 1 chunk +1 line, -2 lines 0 comments Download
M scripts/slave/recipes/webrtc/standalone.expected/tryserver_webrtc_linux_tsan2.json View 1 chunk +1 line, -2 lines 0 comments Download
M scripts/slave/recipes/webrtc/standalone.expected/tryserver_webrtc_linux_ubsan.json View 1 chunk +1 line, -2 lines 0 comments Download
M scripts/slave/recipes/webrtc/standalone.expected/tryserver_webrtc_linux_ubsan_vptr.json View 1 chunk +1 line, -2 lines 0 comments Download
M scripts/slave/recipes/webrtc/standalone.expected/tryserver_webrtc_mac_asan.json View 1 chunk +1 line, -2 lines 0 comments Download
M scripts/slave/recipes/webrtc/standalone.expected/tryserver_webrtc_mac_baremetal.json View 1 chunk +1 line, -2 lines 0 comments Download
M scripts/slave/recipes/webrtc/standalone.expected/tryserver_webrtc_mac_compile_dbg.json View 1 chunk +1 line, -2 lines 0 comments Download
M scripts/slave/recipes/webrtc/standalone.expected/tryserver_webrtc_mac_compile_rel.json View 1 chunk +1 line, -2 lines 0 comments Download
M scripts/slave/recipes/webrtc/standalone.expected/tryserver_webrtc_mac_dbg.json View 1 chunk +1 line, -2 lines 0 comments Download
M scripts/slave/recipes/webrtc/standalone.expected/tryserver_webrtc_mac_rel.json View 1 chunk +1 line, -2 lines 0 comments Download
M scripts/slave/recipes/webrtc/standalone.expected/tryserver_webrtc_mac_swarming.json View 1 chunk +1 line, -2 lines 0 comments Download
M scripts/slave/recipes/webrtc/standalone.expected/tryserver_webrtc_win_asan.json View 1 chunk +1 line, -2 lines 0 comments Download
M scripts/slave/recipes/webrtc/standalone.expected/tryserver_webrtc_win_baremetal.json View 1 chunk +1 line, -2 lines 0 comments Download
M scripts/slave/recipes/webrtc/standalone.expected/tryserver_webrtc_win_clang_dbg.json View 1 chunk +1 line, -2 lines 0 comments Download
M scripts/slave/recipes/webrtc/standalone.expected/tryserver_webrtc_win_clang_rel.json View 1 chunk +1 line, -2 lines 0 comments Download
M scripts/slave/recipes/webrtc/standalone.expected/tryserver_webrtc_win_compile_dbg.json View 1 chunk +1 line, -2 lines 0 comments Download
M scripts/slave/recipes/webrtc/standalone.expected/tryserver_webrtc_win_compile_rel.json View 1 chunk +1 line, -2 lines 0 comments Download
M scripts/slave/recipes/webrtc/standalone.expected/tryserver_webrtc_win_compile_x64_dbg.json View 1 chunk +1 line, -2 lines 0 comments Download
M scripts/slave/recipes/webrtc/standalone.expected/tryserver_webrtc_win_compile_x64_rel.json View 1 chunk +1 line, -2 lines 0 comments Download
M scripts/slave/recipes/webrtc/standalone.expected/tryserver_webrtc_win_dbg.json View 1 chunk +1 line, -2 lines 0 comments Download
M scripts/slave/recipes/webrtc/standalone.expected/tryserver_webrtc_win_drmemory_full.json View 1 chunk +1 line, -2 lines 0 comments Download
M scripts/slave/recipes/webrtc/standalone.expected/tryserver_webrtc_win_drmemory_light.json View 1 chunk +1 line, -2 lines 0 comments Download
M scripts/slave/recipes/webrtc/standalone.expected/tryserver_webrtc_win_rel.json View 1 chunk +1 line, -2 lines 0 comments Download
M scripts/slave/recipes/webrtc/standalone.expected/tryserver_webrtc_win_swarming.json View 1 chunk +1 line, -2 lines 0 comments Download
M scripts/slave/recipes/webrtc/standalone.expected/tryserver_webrtc_win_x64_clang_dbg.json View 1 chunk +1 line, -2 lines 0 comments Download
M scripts/slave/recipes/webrtc/standalone.expected/tryserver_webrtc_win_x64_clang_rel.json View 1 chunk +1 line, -2 lines 0 comments Download
M scripts/slave/recipes/webrtc/standalone.expected/tryserver_webrtc_win_x64_dbg.json View 1 chunk +1 line, -2 lines 0 comments Download
M scripts/slave/recipes/webrtc/standalone.expected/tryserver_webrtc_win_x64_rel.json View 1 chunk +1 line, -2 lines 0 comments Download

Messages

Total messages: 7 (3 generated)
kjellander_chromium
I hope this doesn't break in unexpected ways, but I can't think of anything that ...
4 years, 4 months ago (2016-08-16 12:07:28 UTC) #2
ehmaldonado_chromium
On 2016/08/16 12:07:28, kjellander_chromium wrote: > I hope this doesn't break in unexpected ways, but ...
4 years, 4 months ago (2016-08-16 12:08:50 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2245423002/1
4 years, 4 months ago (2016-08-16 12:09:42 UTC) #5
commit-bot: I haz the power
4 years, 4 months ago (2016-08-16 12:13:53 UTC) #7
Message was sent while issue was closed. 
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/tools/build/+/d3dba1d2122e52ccb3de...

Powered by Google App Engine
This is Rietveld 408576698