Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(920)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: Source/core/html/HTMLMediaElement.cpp

Issue 22454003: Support subtitles for native fullscreen video (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: add dangling pointer check Created 7 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« Source/core/dom/Document.cpp ('K') | « Source/core/features.gypi ('k') | Source/core/html/shadow/MediaControlsChromiumAndroid.h » ('j') | Source/core/rendering/RenderObject.cpp » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/core/html/HTMLMediaElement.cpp
diff --git a/Source/core/html/HTMLMediaElement.cpp b/Source/core/html/HTMLMediaElement.cpp
index 7a0f542984a115d6410af0e774966a8cb963861d..1b64ee2143a54a19ebfc3bf4ccb723f9faa1c433 100644
--- a/Source/core/html/HTMLMediaElement.cpp
+++ b/Source/core/html/HTMLMediaElement.cpp
@@ -3568,6 +3568,7 @@ void HTMLMediaElement::exitFullscreen()
void HTMLMediaElement::didBecomeFullscreenElement()
{
+ Element::didBecomeFullscreenElement();
if (hasMediaControls())
mediaControls()->enteredFullscreen();
}
@@ -3576,6 +3577,7 @@ void HTMLMediaElement::willStopBeingFullscreenElement()
{
if (hasMediaControls())
mediaControls()->exitedFullscreen();
+ Element::willStopBeingFullscreenElement();
}
WebKit::WebLayer* HTMLMediaElement::platformLayer() const
« Source/core/dom/Document.cpp ('K') | « Source/core/features.gypi ('k') | Source/core/html/shadow/MediaControlsChromiumAndroid.h » ('j') | Source/core/rendering/RenderObject.cpp » ('J')

Powered by Google App Engine
This is Rietveld 408576698