Source/core/dom/FullscreenElementStack.cpp - Issue 22454003: Support subtitles for native fullscreen video

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/dom/FullscreenElementStack.cpp

Issue 22454003: Support subtitles for native fullscreen video (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: add dangling pointer check Created 7 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: Source/core/dom/FullscreenElementStack.cpp

diff --git a/Source/core/dom/FullscreenElementStack.cpp b/Source/core/dom/FullscreenElementStack.cpp

index ae70534227109f79feae493f282213399d3dcf32..5a7d55ac77dd4731ee5dd524ef3393d23253e66a 100644

--- a/Source/core/dom/FullscreenElementStack.cpp

+++ b/Source/core/dom/FullscreenElementStack.cpp

@@ -367,11 +367,6 @@ void FullscreenElementStack::webkitWillEnterFullScreenForElement(Element* elemen

m_fullScreenElement = element;

-#if USE(NATIVE_FULLSCREEN_VIDEO)

- if (element && element->isMediaElement())

- return;

-#endif

// Create a placeholder block for a the full-screen element, to keep the page from reflowing

// when the element is removed from the normal flow. Only do this for a RenderBox, as only

// a box will have a frameRect. The placeholder will be created in setFullScreenRenderer()