Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(573)

Unified Diff: Source/core/dom/Document.cpp

Issue 22454003: Support subtitles for native fullscreen video (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: add dangling pointer check Created 7 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Source/core/dom/Document.cpp
diff --git a/Source/core/dom/Document.cpp b/Source/core/dom/Document.cpp
index d2204b62e631cdab5fd099e1337fc6534604b007..0f8038f71c27b088ba17e872dac51447f553269f 100644
--- a/Source/core/dom/Document.cpp
+++ b/Source/core/dom/Document.cpp
@@ -1999,8 +1999,10 @@ void Document::detach(const AttachContext& context)
if (page())
page()->documentDetached(this);
- if (this == topDocument())
+ if (this == topDocument()) {
clearAXObjectCache();
+ renderView()->setCurrentFullscreenRenderer(0);
esprehn 2013/09/20 22:01:09 We're going to destroy the RenderView right after
+ }
stopActiveDOMObjects();
m_eventQueue->close();

Powered by Google App Engine
This is Rietveld 408576698