LayoutTests/fullscreen/video-controls-override.html - Issue 22454003: Support subtitles for native fullscreen video

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: LayoutTests/fullscreen/video-controls-override.html

Issue 22454003: Support subtitles for native fullscreen video (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: add dangling pointer check Created 7 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « LayoutTests/fullscreen/video-controls-drag.html ('k') | LayoutTests/fullscreen/video-controls-timeline.html » ('j') | Source/core/dom/Document.cpp » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: LayoutTests/fullscreen/video-controls-override.html

diff --git a/LayoutTests/fullscreen/video-controls-override.html b/LayoutTests/fullscreen/video-controls-override.html

index 82ce70f1648d3a6bad81ae0af4558b39617cd91e..ccf3f297c9e88bdcb471bb7c62372ea2ab6cdfa5 100644

--- a/LayoutTests/fullscreen/video-controls-override.html

+++ b/LayoutTests/fullscreen/video-controls-override.html

@@ -1,6 +1,10 @@

<body>

<p>This tests that the video element's "controls" attribute is overridden in full screen mode, and that the controls are correctly hidden upon exiting full screen. Press any key to continue.</p>

+ <script>

+ if (window.internals)

+ runPixelTests = internals.runtimeFlags.overlayFullscreenVideoEnabled;

+ </script>

« no previous file with comments | « LayoutTests/fullscreen/video-controls-drag.html ('k') | LayoutTests/fullscreen/video-controls-timeline.html » ('j') | Source/core/dom/Document.cpp » ('J')