LayoutTests/fullscreen/video-specified-size.html - Issue 22454003: Support subtitles for native fullscreen video

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: LayoutTests/fullscreen/video-specified-size.html

Issue 22454003: Support subtitles for native fullscreen video (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: add dangling pointer check Created 7 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch | Annotate | Revision Log

« no previous file with comments | « LayoutTests/fullscreen/video-controls-timeline.html ('k') | LayoutTests/virtual/android/fullscreen/full-screen-stacking-context-expected.png » ('j') | Source/core/dom/Document.cpp » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
1 <body>	1 <body>

2 <video id="video" width="300" controls></video>	2 <video id="video" width="300" controls></video>

	3 <script>

	4 if (window.internals)

	5 runPixelTests = internals.runtimeFlags.overlayFullscreenVideoEnabled ;

	6 </script>

3 <script src="full-screen-test.js"></script>	7 <script src="full-screen-test.js"></script>

4 <script src=../media/media-file.js></script>	8 <script src=../media/media-file.js></script>

5 <script>	9 <script>

6 setSrcById("video", findMediaFile("video", "../media/content/test"));	10 setSrcById("video", findMediaFile("video", "../media/content/test"));

7 var video = document.getElementById('video');	11 var video = document.getElementById('video');

8 // Bail out early if the full screen API is not enabled or is missing:	12 // Bail out early if the full screen API is not enabled or is missing:

9 if (Element.prototype.webkitRequestFullScreen == undefined) {	13 if (Element.prototype.webkitRequestFullScreen == undefined) {

10 logResult(false, "Element.prototype.webkitRequestFullScreen == undef ined");	14 logResult(false, "Element.prototype.webkitRequestFullScreen == undef ined");

11 endTest();	15 endTest();

12 } else {	16 } else {

13 waitForEventTestAndEnd(document, 'webkitfullscreenchange', "video.cl ientWidth==document.body.clientWidth");	17 waitForEventTestAndEnd(document, 'webkitfullscreenchange', "video.cl ientWidth==document.body.clientWidth");

14 runWithKeyDown(function(){video.webkitRequestFullScreen()});	18 runWithKeyDown(function(){video.webkitRequestFullScreen()});

15 }	19 }

16 </script>	20 </script>

17 </body>	21 </body>

OLD	NEW