Support subtitles for native fullscreen video

Source/core/dom/Element.cpp

 /*
  * Copyright (C) 1999 Lars Knoll (knoll@kde.org)
  *           (C) 1999 Antti Koivisto (koivisto@kde.org)
  *           (C) 2001 Peter Kelly (pmk@post.com)
  *           (C) 2001 Dirk Mueller (mueller@kde.org)
  *           (C) 2007 David Smith (catfish.man@gmail.com)
  * Copyright (C) 2004, 2005, 2006, 2007, 2008, 2009, 2010, 2012, 2013 Apple Inc. All rights reserved.
  *           (C) 2007 Eric Seidel (eric@webkit.org)
  *
  * This library is free software; you can redistribute it and/or
@@ skipping 1335 matching lines @@
     if (hasRareData()) {
         ElementRareData* data = elementRareData();
         if (data->needsFocusAppearanceUpdateSoonAfterAttach()) {
             if (isFocusable() && document().focusedElement() == this)
                 document().updateFocusAppearanceSoon(false /* don't restore selection */);
             data->setNeedsFocusAppearanceUpdateSoonAfterAttach(false);
         }
     }
 
     InspectorInstrumentation::didRecalculateStyleForElement(this);
+
+    if (FullscreenElementStack::isActiveFullScreenElement(this)) {
+        if (FrameView* view = document().view())

[esprehn, 2013/09/13 02:46:07]

All the null checks for view() look wrong in here. None of this code should even
run if there's no FrameView.

[trchen, 2013/09/13 05:14:58]

Okay I'll change it to ASSERT.

+            view->setCurrentFullscreenRenderer(renderer());
+    }
 }
 
 void Element::unregisterNamedFlowContentNode()
 {
     if (RuntimeEnabledFeatures::cssRegionsEnabled() && inNamedFlow() && document().renderView())
         document().renderView()->flowThreadController()->unregisterNamedFlowContentNode(this);
 }
 
 void Element::detach(const AttachContext& context)
 {
+    if (FullscreenElementStack::isActiveFullScreenElement(this)) {
+        if (FrameView* view = document().view())
+            view->setCurrentFullscreenRenderer(0);
+    }
+
     WidgetHierarchyUpdatesSuspensionScope suspendWidgetHierarchyUpdates;
     unregisterNamedFlowContentNode();
     cancelFocusAppearanceUpdate();
     if (hasRareData()) {
         ElementRareData* data = elementRareData();
         data->setPseudoElement(BEFORE, 0);
         data->setPseudoElement(AFTER, 0);
         data->setPseudoElement(BACKDROP, 0);
         data->clearComputedStyle();
         data->resetDynamicRestyleObservations();
@@ skipping 2256 matching lines @@
     }
     return 0;
 }
 
 Attribute* UniqueElementData::attributeItem(unsigned index)
 {
     ASSERT_WITH_SECURITY_IMPLICATION(index < length());
     return &m_attributeVector.at(index);
 }
 
+void Element::didBecomeFullscreenElement()
+{
+    FrameView* view = document().view();
+    if (!view)

[esprehn, 2013/09/13 02:46:07]

It should be impossible to get here if there's no FrameView, you don't need
those checks.

[trchen, 2013/09/13 05:14:58]

Will change to ASSERT too.

+        return;
+    view->setCurrentFullscreenRenderer(renderer());
+}
+
+void Element::willStopBeingFullscreenElement()
+{
+    FrameView* view = document().view();
+    if (!view)
+        return;
+    view->setCurrentFullscreenRenderer(0);
+}
+
 } // namespace WebCore