Issue 2245323005: Fix uninitialized member (isolate_) in AstPrinter.

Issue 2245323005: Fix uninitialized member (isolate_) in AstPrinter. (Closed)

Created:
4 years, 4 months ago by georgia.kouveli

Modified:
4 years, 4 months ago

Reviewers:
Benedikt Meurer

CC:
v8-reviews_googlegroups.com

Base URL:
https://chromium.googlesource.com/v8/v8.git@master

Target Ref:
refs/pending/heads/master

Project:
v8

Visibility:
Public.

Fix uninitialized member (isolate_) in AstPrinter. BUG= Committed: https://crrev.com/931ac008bb5ff709d3d58e88bb5a432c4faf644d Cr-Commit-Position: refs/heads/master@{#38690}

Created: 4 years, 4 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -1 line)			Patch
	M	src/ast/prettyprinter.cc	View		1 chunk	+1 line, -1 line	0 comments	Download

Total messages: 8 (3 generated)

georgia.kouveli

This was causing a segfault when using --print-ast.

4 years, 4 months ago (2016-08-17 13:10:30 UTC) #2

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2245323005/1

4 years, 4 months ago (2016-08-17 17:05:12 UTC) #5

commit-bot: I haz the power

4 years, 4 months ago (2016-08-17 17:43:09 UTC) #8

Message was sent while issue was closed.

Patchset 1 (id:??) landed as
https://crrev.com/931ac008bb5ff709d3d58e88bb5a432c4faf644d
Cr-Commit-Position: refs/heads/master@{#38690}