Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(40)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2245303004: Interpret collected iOS Swarming task results (Closed)

Created:
4 years, 4 months ago by smut
Modified:
4 years, 4 months ago
Reviewers:
Dirk Pranke, dpranke
CC:
chromium-reviews, infra-reviews+build_chromium.org, kjellander-cc_chromium.org
Target Ref:
refs/heads/master
Project:
build
Visibility:
Public.

Description

Patch Set 1 #

Total comments: 4
Unified diffs Side-by-side diffs Delta from patch set Stats (+234 lines, -163 lines) Patch
M scripts/slave/recipe_modules/ios/api.py View 2 chunks +57 lines, -4 lines 4 comments Download
M scripts/slave/recipe_modules/ios/example.py View 1 chunk +163 lines, -0 lines 0 comments Download
M scripts/slave/recipe_modules/ios/example.expected/errors.json View 1 chunk +1 line, -0 lines 0 comments Download
A + scripts/slave/recipe_modules/ios/example.expected/expired.json View 1 chunk +3 lines, -33 lines 0 comments Download
A + scripts/slave/recipe_modules/ios/example.expected/infra_failure.json View 1 chunk +3 lines, -31 lines 0 comments Download
A + scripts/slave/recipe_modules/ios/example.expected/no_exit_code.json View 1 chunk +3 lines, -33 lines 0 comments Download
M scripts/slave/recipe_modules/ios/example.expected/test_failure.json View 1 chunk +2 lines, -30 lines 0 comments Download
A + scripts/slave/recipe_modules/ios/example.expected/timed_out.json View 1 chunk +2 lines, -32 lines 0 comments Download

Messages

Total messages: 10 (5 generated)
smut
4 years, 4 months ago (2016-08-16 23:47:39 UTC) #3
Dirk Pranke
generally lgtm, w/ a couple of suggestions. https://codereview.chromium.org/2245303004/diff/20001/scripts/slave/recipe_modules/ios/api.py File scripts/slave/recipe_modules/ios/api.py (right): https://codereview.chromium.org/2245303004/diff/20001/scripts/slave/recipe_modules/ios/api.py#newcode750 scripts/slave/recipe_modules/ios/api.py:750: if self.m.path.exists(test_summary): ...
4 years, 4 months ago (2016-08-17 01:53:58 UTC) #5
smut
https://codereview.chromium.org/2245303004/diff/20001/scripts/slave/recipe_modules/ios/api.py File scripts/slave/recipe_modules/ios/api.py (right): https://codereview.chromium.org/2245303004/diff/20001/scripts/slave/recipe_modules/ios/api.py#newcode750 scripts/slave/recipe_modules/ios/api.py:750: if self.m.path.exists(test_summary): # pragma: no cover On 2016/08/17 01:53:58, ...
4 years, 4 months ago (2016-08-17 21:51:57 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2245303004/20001
4 years, 4 months ago (2016-08-17 22:00:03 UTC) #8
commit-bot: I haz the power
4 years, 4 months ago (2016-08-17 22:03:47 UTC) #10
Message was sent while issue was closed. 
Committed patchset #1 (id:20001) as
https://chromium.googlesource.com/chromium/tools/build/+/31a33ab94ae00abc12d5...

Powered by Google App Engine
This is Rietveld 408576698