Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(139)

Issue 22453004: If any change is made to the public API then make sure there is an LGTM from an owner (Closed)

Created:
7 years, 4 months ago by rmistry
Modified:
7 years, 4 months ago
Reviewers:
borenet
CC:
skia-review_googlegroups.com, skiabot_google.com, reed1, bsalomon
Visibility:
Public.

Description

If any change is made to the public API then make sure there is an LGTM from an owner. This feature has been requested by reed@. If no LGTM is found from an owner then the following msg is displayed: ** Presubmit ERRORS ** Since the CL is editing public API, you must have an LGTM from one of: ('reed@chromium.org', 'reed@google.com', 'bsalomon@chromium.org', 'bsalomon@google.com') (SkipBuildbotRuns) R=borenet@google.com Committed: https://code.google.com/p/skia/source/detail?r=10676

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+52 lines, -0 lines) Patch
M PRESUBMIT.py View 1 3 chunks +52 lines, -0 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
rmistry
7 years, 4 months ago (2013-08-08 14:30:19 UTC) #1
borenet
LGTM. I wonder if there's a smarter way to determine whether the public API has ...
7 years, 4 months ago (2013-08-12 14:22:13 UTC) #2
rmistry
On 2013/08/12 14:22:13, borenet wrote: > LGTM. I wonder if there's a smarter way to ...
7 years, 4 months ago (2013-08-12 14:43:13 UTC) #3
rmistry
7 years, 4 months ago (2013-08-12 14:51:23 UTC) #4
Message was sent while issue was closed.
Committed patchset #2 manually as r10676.

Powered by Google App Engine
This is Rietveld 408576698