Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1023)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2245283002: [DevTools] Send correct message level in deprecated Console domain. (Closed)

Created:
4 years, 4 months ago by dgozman
Modified:
4 years, 4 months ago
Reviewers:
pfeldman
CC:
chromium-reviews, caseq+blink_chromium.org, lushnikov+blink_chromium.org, pfeldman+blink_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, blink-reviews, kozyatinskiy+blink_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[DevTools] Send correct message level in deprecated Console domain. BUG=613882 Committed: https://crrev.com/3d4a7bcdbde61bb3d550dcf4e23f03c0c84da435 Cr-Commit-Position: refs/heads/master@{#412146}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -1 line) Patch
M third_party/WebKit/Source/platform/v8_inspector/V8ConsoleMessage.cpp View 1 chunk +10 lines, -1 line 0 comments Download

Messages

Total messages: 8 (3 generated)
dgozman
Take a look please.
4 years, 4 months ago (2016-08-15 23:25:57 UTC) #2
pfeldman
lgtm
4 years, 4 months ago (2016-08-16 01:05:29 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2245283002/1
4 years, 4 months ago (2016-08-16 01:12:59 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 4 months ago (2016-08-16 02:41:13 UTC) #6
commit-bot: I haz the power
4 years, 4 months ago (2016-08-16 02:42:44 UTC) #8
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/3d4a7bcdbde61bb3d550dcf4e23f03c0c84da435
Cr-Commit-Position: refs/heads/master@{#412146}

Powered by Google App Engine
This is Rietveld 408576698