Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(487)

Issue 2245263007: Add --issue to set-commit and set-close too. (Closed)

Created:
4 years, 4 months ago by iannucci
Modified:
4 years, 4 months ago
CC:
chromium-reviews, dpranke+depot_tools_chromium.org, iannucci+depot_tools_chromium.org, tandrii+omg_git_cl_chromium.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+71 lines, -16 lines) Patch
M git_cl.py View 4 chunks +29 lines, -13 lines 0 comments Download
M tests/git_cl_test.py View 4 chunks +42 lines, -3 lines 2 comments Download

Messages

Total messages: 7 (2 generated)
Paweł Hajdan Jr.
LGTM
4 years, 4 months ago (2016-08-17 20:53:33 UTC) #1
tandrii(chromium)
LGTM I wanted to do this earlier, but at the time there bits of code ...
4 years, 4 months ago (2016-08-17 21:05:31 UTC) #2
iannucci
https://codereview.chromium.org/2245263007/diff/1/tests/git_cl_test.py File tests/git_cl_test.py (right): https://codereview.chromium.org/2245263007/diff/1/tests/git_cl_test.py#newcode1592 tests/git_cl_test.py:1592: def test_SetCommitOverrideIssue(self): On 2016/08/17 at 21:05:31, tandrii(chromium) wrote: > ...
4 years, 4 months ago (2016-08-17 21:37:08 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2245263007/1
4 years, 4 months ago (2016-08-17 21:37:10 UTC) #5
commit-bot: I haz the power
4 years, 4 months ago (2016-08-17 21:40:44 UTC) #7
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/tools/depot_tools/+/e53c935fe76b05...

Powered by Google App Engine
This is Rietveld 408576698