[interpreter] Fix canonicalization when preserving bytecode.

[interpreter] Fix canonicalization when preserving bytecode.

This fixes canonicalization of {SharedFunctionInfo} objects in the
{Compiler::GetSharedFunctionInfo} method when bytecode is preserved.
Eager compilation is only triggered when no code is present.

R=rmcilroy@chromium.org
TEST=mjsunit/regress/regress-crbug-638551
BUG=chromium:638551
Committed: https://crrev.com/8ab555cc15cb0095ba16ab9394a93e9e620e8e3a
Cr-Commit-Position: refs/heads/master@{#38709}

[Michael Starzinger, 2016-08-17 12:46:35]

The CQ bit was checked by mstarzinger@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-08-17 12:46:43]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-17 13:10:16]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-17 13:10:17]

Dry run: This issue passed the CQ dry run.

[rmcilroy, 2016-08-18 10:26:06]

LGTM with one comment.

https://codereview.chromium.org/2245263006/diff/20001/src/compiler.cc
File src/compiler.cc (right):

https://codereview.chromium.org/2245263006/diff/20001/src/compiler.cc#newcode...
src/compiler.cc:1767: if (!outer_info->is_debug() || existing->HasDebugCode()) {
Should this be HasDebugCode() || HasDebugBytecode()?

[rmcilroy, 2016-08-18 10:29:03]

https://codereview.chromium.org/2245263006/diff/20001/src/compiler.cc
File src/compiler.cc (right):

https://codereview.chromium.org/2245263006/diff/20001/src/compiler.cc#newcode...
src/compiler.cc:1767: if (!outer_info->is_debug() || existing->HasDebugCode()) {
On 2016/08/18 10:26:06, rmcilroy wrote:
> Should this be HasDebugCode() || HasDebugBytecode()?

Sorry ignore this, HasDebugCode does what I though needed to be done.

[Michael Starzinger, 2016-08-18 10:40:29]

The CQ bit was checked by mstarzinger@chromium.org

[commit-bot: I haz the power, 2016-08-18 10:40:35]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-18 10:42:34]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-08-18 10:42:47]

Description was changed from

==========
[interpreter] Fix canonicalization when preserving bytecode.

This fixes canonicalization of {SharedFunctionInfo} objects in the
{Compiler::GetSharedFunctionInfo} method when bytecode is preserved.
Eager compilation is only triggered when no code is present.

R=rmcilroy@chromium.org
TEST=mjsunit/regress/regress-crbug-638551
BUG=chromium:638551
==========

to

==========
[interpreter] Fix canonicalization when preserving bytecode.

This fixes canonicalization of {SharedFunctionInfo} objects in the
{Compiler::GetSharedFunctionInfo} method when bytecode is preserved.
Eager compilation is only triggered when no code is present.

R=rmcilroy@chromium.org
TEST=mjsunit/regress/regress-crbug-638551
BUG=chromium:638551

Committed: https://crrev.com/8ab555cc15cb0095ba16ab9394a93e9e620e8e3a
Cr-Commit-Position: refs/heads/master@{#38709}
==========

[commit-bot: I haz the power, 2016-08-18 10:42:48]

Patchset 2 (id:??) landed as
https://crrev.com/8ab555cc15cb0095ba16ab9394a93e9e620e8e3a
Cr-Commit-Position: refs/heads/master@{#38709}