Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(66)

Issue 2245263005: Split HTMLFormElement::m_isSubmittingOrInUserJSSubmitEvent. (Closed)

Created:
4 years, 4 months ago by tkent
Modified:
4 years, 4 months ago
Reviewers:
keishi
CC:
blink-reviews, blink-reviews-html_chromium.org, chromium-reviews, dglazkov+blink
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Split HTMLFormElement::m_isSubmittingOrInUserJSSubmitEvent. This CL splits HTMLFormElement::m_isSubmittingOrInUserJSSubmitEvent into m_isSubmitting and m_inUserJSSubmitEvent. - This is a preparation to fix crbug.com/196640. - Use WTF::AutoReset, which can't apply to bitfields. - This has no behavior changes. BUG=196640 Committed: https://crrev.com/f3468bf880d95d79b516ee19cbe6f1807f7e5c61 Cr-Commit-Position: refs/heads/master@{#412539}

Patch Set 1 #

Total comments: 1

Patch Set 2 : Change the order of AutoReset<> and EventQueueScope #

Unified diffs Side-by-side diffs Delta from patch set Stats (+21 lines, -21 lines) Patch
M third_party/WebKit/Source/core/html/HTMLFormElement.h View 1 chunk +3 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/core/html/HTMLFormElement.cpp View 1 6 chunks +18 lines, -17 lines 0 comments Download

Messages

Total messages: 20 (14 generated)
tkent
Keishi, would you review this please?
4 years, 4 months ago (2016-08-17 08:15:10 UTC) #4
keishi
LGTM
4 years, 4 months ago (2016-08-17 11:20:19 UTC) #8
tkent
https://codereview.chromium.org/2245263005/diff/1/third_party/WebKit/Source/core/html/HTMLFormElement.cpp File third_party/WebKit/Source/core/html/HTMLFormElement.cpp (left): https://codereview.chromium.org/2245263005/diff/1/third_party/WebKit/Source/core/html/HTMLFormElement.cpp#oldcode392 third_party/WebKit/Source/core/html/HTMLFormElement.cpp:392: m_isSubmittingOrInUserJSSubmitEvent = false; Layout test submit-dialog-close-event.html failed because of ...
4 years, 4 months ago (2016-08-17 14:02:58 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2245263005/20001
4 years, 4 months ago (2016-08-17 15:51:15 UTC) #17
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 4 months ago (2016-08-17 15:55:11 UTC) #18
commit-bot: I haz the power
4 years, 4 months ago (2016-08-17 15:57:07 UTC) #20
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/f3468bf880d95d79b516ee19cbe6f1807f7e5c61
Cr-Commit-Position: refs/heads/master@{#412539}

Powered by Google App Engine
This is Rietveld 408576698