Add --csv argument to find_unmapped_histograms.py

Add --csv argument to find_unmapped_histograms.py

The --csv argument makes find_unmapped_histograms.py report unmapped
histograms in CSV format instead of logging them.

This makes it easier to digest the output in other software.

R=isherman@chromium.org
BUG=

Committed: https://crrev.com/4c838bd1f2e4b4be25ec0886634c31339109311d
Cr-Commit-Position: refs/heads/master@{#412755}

[Adam Rice, 2016-08-17 06:14:02]

I did this for my own use. I don't know whether it is generally useful. I will
submit it if you think it is.

[Ilya Sherman, 2016-08-17 22:09:24]

LGTM, thanks!  I don't know whether this will end up being generally useful, but
it's not a lot of extra code or complexity to maintain, so I don't see any harm
in adding it.  (This script is run by only a handful of people, so generally
anything that makes it useful to one of those people tends to be worth landing.)

https://codereview.chromium.org/2245263004/diff/1/tools/metrics/histograms/fi...
File tools/metrics/histograms/find_unmapped_histograms.py (right):

https://codereview.chromium.org/2245263004/diff/1/tools/metrics/histograms/fi...
tools/metrics/histograms/find_unmapped_histograms.py:294: (filename,
line_number) = location_map[histogram].split(':', 1)
Hmm, is it really necessary to include the max-split arg of 1?  Presumably it
shouldn't be possible to have more than a single colon -- that's better handled
as an assertion, IMO.

https://codereview.chromium.org/2245263004/diff/1/tools/metrics/histograms/fi...
tools/metrics/histograms/find_unmapped_histograms.py:344: '--csv',
action='store_true', dest='csv', default=False,
nit: Let's name this variable 'output_as_csv' rather than just 'csv' (just for
the dest variable, not for the flag).

[Adam Rice, 2016-08-18 05:26:33]

The CQ bit was checked by ricea@chromium.org

[Adam Rice, 2016-08-18 05:26:34]

The patchset sent to the CQ was uploaded after l-g-t-m from
isherman@chromium.org
Link to the patchset: https://codereview.chromium.org/2245263004/#ps20001
(title: "Fix nits")

[commit-bot: I haz the power, 2016-08-18 05:26:50]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-18 06:10:01]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-08-18 06:11:28]

Description was changed from

==========
Add --csv argument to find_unmapped_histograms.py

The --csv argument makes find_unmapped_histograms.py report unmapped
histograms in CSV format instead of logging them.

This makes it easier to digest the output in other software.

R=isherman@chromium.org
BUG=
==========

to

==========
Add --csv argument to find_unmapped_histograms.py

The --csv argument makes find_unmapped_histograms.py report unmapped
histograms in CSV format instead of logging them.

This makes it easier to digest the output in other software.

R=isherman@chromium.org
BUG=

Committed: https://crrev.com/4c838bd1f2e4b4be25ec0886634c31339109311d
Cr-Commit-Position: refs/heads/master@{#412755}
==========

[commit-bot: I haz the power, 2016-08-18 06:11:29]

Patchset 2 (id:??) landed as
https://crrev.com/4c838bd1f2e4b4be25ec0886634c31339109311d
Cr-Commit-Position: refs/heads/master@{#412755}