Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(710)

Issue 2245263003: [turbofan] Tests for inlining calls, constructors, property access inside try..catch..finally. (Closed)

Created:
4 years, 4 months ago by bgeron
Modified:
4 years, 3 months ago
Reviewers:
Jarin
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@p6-base
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[turbofan] Tests for inlining calls, constructors, property access inside try..catch..finally. These tests were spliced out of changelist 2216353002 and extended. BUG= Committed: https://crrev.com/244d9ccd40d5c8b251a4e359bd5c85a239ae0a04 Cr-Commit-Position: refs/heads/master@{#38906}

Patch Set 1 #

Patch Set 2 : Add flag letters in debugnames. Add deopt flag. Two extra variants: CallConstructor and properties.… #

Patch Set 3 : Various changes. #

Patch Set 4 : Wrap long lines. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4600 lines, -0 lines) Patch
A test/mjsunit/compiler/inline-exception-1.js View 1 2 3 1 chunk +2121 lines, -0 lines 0 comments Download
A test/mjsunit/compiler/inline-exception-2.js View 1 2 3 1 chunk +1969 lines, -0 lines 0 comments Download
A tools/gen-inlining-tests.py View 1 2 3 1 chunk +510 lines, -0 lines 0 comments Download

Dependent Patchsets:

Messages

Total messages: 25 (18 generated)
bgeron
Please take a look. This CL is only the tests from the other CL, in ...
4 years, 4 months ago (2016-08-18 14:51:41 UTC) #9
Jarin
Could you split the test into several parts? The largest test in the mjsunit directory ...
4 years, 4 months ago (2016-08-19 08:17:07 UTC) #12
bgeron
Various changes. - Lots of more pruning. - Remove TODO that was left - Add ...
4 years, 3 months ago (2016-08-25 11:12:52 UTC) #15
Jarin
lgtm, but format lines to be within 80 characters, please.
4 years, 3 months ago (2016-08-25 11:57:51 UTC) #18
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2245263003/60001
4 years, 3 months ago (2016-08-25 12:28:16 UTC) #21
commit-bot: I haz the power
Committed patchset #4 (id:60001)
4 years, 3 months ago (2016-08-25 12:50:40 UTC) #23
commit-bot: I haz the power
4 years, 3 months ago (2016-08-25 12:50:59 UTC) #25
Message was sent while issue was closed.
Patchset 4 (id:??) landed as
https://crrev.com/244d9ccd40d5c8b251a4e359bd5c85a239ae0a04
Cr-Commit-Position: refs/heads/master@{#38906}

Powered by Google App Engine
This is Rietveld 408576698