remoting/host/BUILD.gn - Issue 2245253002: [Chromoting] Disable remoting_host_installation in component build

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: remoting/host/BUILD.gn

Issue 2245253002: [Chromoting] Disable remoting_host_installation in component build (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: remoting/host/BUILD.gn

diff --git a/remoting/host/BUILD.gn b/remoting/host/BUILD.gn

index c3ade73772302a380539903db4557e2e2633c7c1..cf1c9d143394109e0d61c4ec263b70836c6701ca 100644

--- a/remoting/host/BUILD.gn

+++ b/remoting/host/BUILD.gn

@@ -1642,7 +1642,7 @@ if (enable_me2me_host) {

if (is_win && is_chrome_branded) {

# We do not release a 64 bits binary. So to avoid any potential

# misunderstanding, we only build 32 bits MSI file.

- if (target_cpu == "x86") {

+ if (is_component_build && target_cpu == "x86") {

joedow 2016/08/15 23:08:53 Shouldn't this be: if (!is_component_build && targ

Hzj_jie 2016/08/15 23:12:17 Faint.

# The script uses "ia32" instead of "x86".

msi_script_arch = "ia32"

« no previous file with comments | « no previous file | no next file » | no next file with comments »