[Chromoting] Disable remoting_host_installation in component build

[Chromoting] Disable remoting_host_installation in component build

Dll dependencies are hard to maintain, so we disable remoting_host_installation
in component build.

BUG=633368
Committed: https://crrev.com/f7cf182958b7d85352fec709fc823956032bab3c
Cr-Commit-Position: refs/heads/master@{#412110}

[Hzj_jie, 2016-08-15 22:16:04]

The CQ bit was checked by zijiehe@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-08-15 22:16:41]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-15 23:05:02]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-15 23:05:03]

Dry run: This issue passed the CQ dry run.

[Hzj_jie, 2016-08-15 23:05:50]

Description was changed from

==========
[Chromoting] Disable remoting_host_installation in component build

Dll dependencies are hard to maintain, so we disable remoting_host_installation
in component build.

BUG=633368
==========

to

==========
[Chromoting] Disable remoting_host_installation in component build

Dll dependencies are hard to maintain, so we disable remoting_host_installation
in component build.

BUG=633368
==========

[Hzj_jie, 2016-08-15 23:05:50]

zijiehe@chromium.org changed reviewers:
+ joedow@chromium.org

[joedow, 2016-08-15 23:08:53]

https://codereview.chromium.org/2245253002/diff/1/remoting/host/BUILD.gn
File remoting/host/BUILD.gn (right):

https://codereview.chromium.org/2245253002/diff/1/remoting/host/BUILD.gn#newc...
remoting/host/BUILD.gn:1645: if (is_component_build && target_cpu == "x86") {
Shouldn't this be:
if (!is_component_build && target_cpu == "x86") {

[Hzj_jie, 2016-08-15 23:11:34]

The CQ bit was checked by zijiehe@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-08-15 23:12:04]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Hzj_jie, 2016-08-15 23:12:17]

https://codereview.chromium.org/2245253002/diff/1/remoting/host/BUILD.gn
File remoting/host/BUILD.gn (right):

https://codereview.chromium.org/2245253002/diff/1/remoting/host/BUILD.gn#newc...
remoting/host/BUILD.gn:1645: if (is_component_build && target_cpu == "x86") {
On 2016/08/15 23:08:53, joedow wrote:
> Shouldn't this be:
> if (!is_component_build && target_cpu == "x86") {

Faint.

[joedow, 2016-08-15 23:14:24]

lgtm

[commit-bot: I haz the power, 2016-08-16 00:15:29]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-16 00:15:30]

Dry run: This issue passed the CQ dry run.

[Hzj_jie, 2016-08-16 00:16:08]

The CQ bit was checked by zijiehe@chromium.org

[commit-bot: I haz the power, 2016-08-16 00:16:34]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-16 00:21:08]

Description was changed from

==========
[Chromoting] Disable remoting_host_installation in component build

Dll dependencies are hard to maintain, so we disable remoting_host_installation
in component build.

BUG=633368
==========

to

==========
[Chromoting] Disable remoting_host_installation in component build

Dll dependencies are hard to maintain, so we disable remoting_host_installation
in component build.

BUG=633368
==========

[commit-bot: I haz the power, 2016-08-16 00:21:09]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-08-16 00:24:50]

Description was changed from

==========
[Chromoting] Disable remoting_host_installation in component build

Dll dependencies are hard to maintain, so we disable remoting_host_installation
in component build.

BUG=633368
==========

to

==========
[Chromoting] Disable remoting_host_installation in component build

Dll dependencies are hard to maintain, so we disable remoting_host_installation
in component build.

BUG=633368

Committed: https://crrev.com/f7cf182958b7d85352fec709fc823956032bab3c
Cr-Commit-Position: refs/heads/master@{#412110}
==========

[commit-bot: I haz the power, 2016-08-16 00:24:51]

Patchset 2 (id:??) landed as
https://crrev.com/f7cf182958b7d85352fec709fc823956032bab3c
Cr-Commit-Position: refs/heads/master@{#412110}