chrome/chrome_browser.gypi - Issue 2245213002: Add PageLoad.* metrics for Offline Previews

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/chrome_browser.gypi

Issue 2245213002: Add PageLoad.* metrics for Offline Previews (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Self review Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/chrome_browser.gypi

diff --git a/chrome/chrome_browser.gypi b/chrome/chrome_browser.gypi

index 54cdb8e1db7ef5b7f85d906d0d5966325f9bd771..e8bec2c376c3ef84e753372c3f356297fbfd1f18 100644

--- a/chrome/chrome_browser.gypi

+++ b/chrome/chrome_browser.gypi

@@ -408,20 +408,22 @@

'browser/page_load_metrics/observers/from_gws_page_load_metrics_observer.cc',

'browser/page_load_metrics/observers/from_gws_page_load_metrics_observer.h',

'browser/page_load_metrics/observers/google_captcha_observer.cc',

'browser/page_load_metrics/observers/google_captcha_observer.h',

'browser/page_load_metrics/observers/https_engagement_metrics/https_engagement_page_load_metrics_observer.cc',

'browser/page_load_metrics/observers/https_engagement_metrics/https_engagement_page_load_metrics_observer.h',

'browser/page_load_metrics/observers/https_engagement_metrics/https_engagement_service.cc',

'browser/page_load_metrics/observers/https_engagement_metrics/https_engagement_service.h',

'browser/page_load_metrics/observers/https_engagement_metrics/https_engagement_service_factory.cc',

'browser/page_load_metrics/observers/https_engagement_metrics/https_engagement_service_factory.h',

+ 'browser/page_load_metrics/observers/previews_page_load_metrics_observer.cc',

+ 'browser/page_load_metrics/observers/previews_page_load_metrics_observer.h',

'browser/page_load_metrics/observers/service_worker_page_load_metrics_observer.cc',

'browser/page_load_metrics/observers/service_worker_page_load_metrics_observer.h',

'browser/page_load_metrics/observers/stale_while_revalidate_metrics_observer.cc',

'browser/page_load_metrics/observers/stale_while_revalidate_metrics_observer.h',

'browser/page_load_metrics/page_load_metrics_initialize.cc',

'browser/page_load_metrics/page_load_metrics_initialize.h',

'browser/page_load_metrics/page_load_metrics_observer.cc',

'browser/page_load_metrics/page_load_metrics_observer.h',

'browser/page_load_metrics/page_load_metrics_util.cc',

'browser/page_load_metrics/page_load_metrics_util.h',