Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3814)

Unified Diff: chrome/browser/page_load_metrics/observers/previews_page_load_metrics_observer.h

Issue 2245213002: Add PageLoad.* metrics for Offline Previews (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: csharrison comments Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/page_load_metrics/observers/previews_page_load_metrics_observer.h
diff --git a/chrome/browser/page_load_metrics/observers/previews_page_load_metrics_observer.h b/chrome/browser/page_load_metrics/observers/previews_page_load_metrics_observer.h
new file mode 100644
index 0000000000000000000000000000000000000000..3ce06e41480b5a503324735b53dce882024fe550
--- /dev/null
+++ b/chrome/browser/page_load_metrics/observers/previews_page_load_metrics_observer.h
@@ -0,0 +1,71 @@
+// Copyright 2016 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#ifndef CHROME_BROWSER_PAGE_LOAD_METRICS_OBSERVERS_PREVIEWS_PAGE_LOAD_METRICS_OBSERVER_H_
+#define CHROME_BROWSER_PAGE_LOAD_METRICS_OBSERVERS_PREVIEWS_PAGE_LOAD_METRICS_OBSERVER_H_
+
+#include "base/macros.h"
+#include "chrome/browser/page_load_metrics/page_load_metrics_observer.h"
+
+namespace content {
+class NavigationHandle;
+class WebContents;
+}
+
+namespace page_load_metrics {
+struct PageLoadExtraInfo;
+struct PageLoadTiming;
+}
+
+namespace previews {
+
+namespace internal {
+
+// Various UMA histogram names for Previews core page load metrics.
+extern const char kHistogramOfflinePreviewsDOMContentLoadedEventFired[];
+extern const char kHistogramOfflinePreviewsFirstLayout[];
+extern const char kHistogramOfflinePreviewsLoadEventFired[];
+extern const char kHistogramOfflinePreviewsFirstContentfulPaint[];
+extern const char kHistogramOfflinePreviewsParseStart[];
+
+} // namespace internal
+
+// Observer responsible for recording core page load metrics relevant to
+// Previews.
+class PreviewsPageLoadMetricsObserver
+ : public page_load_metrics::PageLoadMetricsObserver {
+ public:
+ PreviewsPageLoadMetricsObserver();
+ ~PreviewsPageLoadMetricsObserver() override;
+
+ // page_load_metrics::PageLoadMetricsObserver:
+ void OnCommit(content::NavigationHandle* navigation_handle) override;
+ void OnDomContentLoadedEventStart(
+ const page_load_metrics::PageLoadTiming& timing,
+ const page_load_metrics::PageLoadExtraInfo& info) override;
+ void OnLoadEventStart(
+ const page_load_metrics::PageLoadTiming& timing,
+ const page_load_metrics::PageLoadExtraInfo& info) override;
+ void OnFirstLayout(const page_load_metrics::PageLoadTiming& timing,
+ const page_load_metrics::PageLoadExtraInfo& info) override;
+ void OnFirstContentfulPaint(
+ const page_load_metrics::PageLoadTiming& timing,
+ const page_load_metrics::PageLoadExtraInfo& info) override;
+ void OnParseStart(const page_load_metrics::PageLoadTiming& timing,
+ const page_load_metrics::PageLoadExtraInfo& info) override;
+
+ private:
+ // Whether |web_contents| is showing an offline pages preview. Overridden in
+ // testing.
+ virtual bool IsOfflinePreview(content::WebContents* web_contents) const;
+
+ // Whether this page load was an offline pages preview.
+ bool is_offline_preview_;
+
+ DISALLOW_COPY_AND_ASSIGN(PreviewsPageLoadMetricsObserver);
+};
+
+} // namespace previews
+
+#endif // CHROME_BROWSER_PAGE_LOAD_METRICS_OBSERVERS_PREVIEWS_PAGE_LOAD_METRICS_OBSERVER_H_

Powered by Google App Engine
This is Rietveld 408576698