tools/metrics/histograms/histograms.xml - Issue 2245213002: Add PageLoad.* metrics for Offline Previews

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tools/metrics/histograms/histograms.xml

Side-by-side diff isn't available for this file because of its large size.

Issue 2245213002: Add PageLoad.* metrics for Offline Previews (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Self review Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: tools/metrics/histograms/histograms.xml

diff --git a/tools/metrics/histograms/histograms.xml b/tools/metrics/histograms/histograms.xml

index 41d9d2185ad12396f0720b5b113db432ff2839a1..6b76d796285e9f91a1737f5c2754e09944a4c158 100644

--- a/tools/metrics/histograms/histograms.xml

+++ b/tools/metrics/histograms/histograms.xml

@@ -101063,20 +101063,24 @@ To add a new entry, add it with any value and run test to compute valid value.

<suffix name="Clients.DataReductionProxy"

label="PageLoadMetrics that are a result of a navigation through the

data reduction proxy."/>

<suffix name="Clients.DataReductionProxy.LoFiOn"

label="PageLoadMetrics that are a result of a navigation through the

data reduction proxy with session in LoFi enabled or control

field trial, and when the connection was slow."/>

<suffix name="Clients.DocWrite.Evaluator"

label="PageLoadMetrics from a page that could have been evaluated by

the DocumentWriteEvaluator"/>

+ <suffix name="Clients.Previews.OfflinePages"

+ label="PageLoadMetrics that are a result of a navigation that shows

+ users an offline page preview. Offline page previews are shown

+ when a users effective connection type is prohibitvely slow."/>

tbansal1 2016/08/18 22:04:53 s/users/user's/

tbansal1 2016/08/18 22:04:53 typo in "prohibitvely".

RyanSturm 2016/08/19 19:10:38 Done.

<suffix name="Clients.ServiceWorker"

label="PageLoadMetrics from a page that is controlled by a Service

Worker"/>

<affected-histogram

name="PageLoad.Timing2.DOMLoadingToDOMContentLoadedEventFired"/>

<affected-histogram name="PageLoad.Timing2.DOMLoadingToFirstContentfulPaint"/>

<suffix name="Clients.DocWrite.Block"

label="PageLoadMetrics from a page that has synchronous, cross-origin

document.written scripts that could be blocked if the

document.write script blocking feature is enabled."/>