Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(106)

Side by Side Diff: chrome/browser/page_load_metrics/observers/previews_page_load_metrics_observer.h

Issue 2245213002: Add PageLoad.* metrics for Offline Previews (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: csharrison comments Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
(Empty)
1 // Copyright 2016 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file.
4
5 #ifndef CHROME_BROWSER_PAGE_LOAD_METRICS_OBSERVERS_PREVIEWS_PAGE_LOAD_METRICS_OB SERVER_H_
6 #define CHROME_BROWSER_PAGE_LOAD_METRICS_OBSERVERS_PREVIEWS_PAGE_LOAD_METRICS_OB SERVER_H_
7
8 #include "base/macros.h"
9 #include "chrome/browser/page_load_metrics/page_load_metrics_observer.h"
10
11 namespace content {
12 class NavigationHandle;
13 class WebContents;
14 }
15
16 namespace page_load_metrics {
17 struct PageLoadExtraInfo;
18 struct PageLoadTiming;
19 }
20
21 namespace previews {
22
23 namespace internal {
24
25 // Various UMA histogram names for Previews core page load metrics.
26 extern const char kHistogramOfflinePreviewsPrefix[];
Charlie Harrison 2016/08/19 20:34:14 No longer needed.
RyanSturm 2016/08/19 20:39:49 Done.
27 extern const char kHistogramDOMContentLoadedEventFired[];
Charlie Harrison 2016/08/19 20:34:14 These should have Preview somewhere in the name.
RyanSturm 2016/08/19 20:39:49 Done.
28 extern const char kHistogramFirstLayout[];
29 extern const char kHistogramLoadEventFired[];
30 extern const char kHistogramFirstContentfulPaint[];
31 extern const char kHistogramParseStart[];
32
33 } // namespace internal
34
35 // Observer responsible for recording core page load metrics relevant to
36 // Previews.
37 class PreviewsPageLoadMetricsObserver
38 : public page_load_metrics::PageLoadMetricsObserver {
39 public:
40 PreviewsPageLoadMetricsObserver();
41 ~PreviewsPageLoadMetricsObserver() override;
42
43 // page_load_metrics::PageLoadMetricsObserver:
44 void OnCommit(content::NavigationHandle* navigation_handle) override;
45 void OnDomContentLoadedEventStart(
46 const page_load_metrics::PageLoadTiming& timing,
47 const page_load_metrics::PageLoadExtraInfo& info) override;
48 void OnLoadEventStart(
49 const page_load_metrics::PageLoadTiming& timing,
50 const page_load_metrics::PageLoadExtraInfo& info) override;
51 void OnFirstLayout(const page_load_metrics::PageLoadTiming& timing,
52 const page_load_metrics::PageLoadExtraInfo& info) override;
53 void OnFirstContentfulPaint(
54 const page_load_metrics::PageLoadTiming& timing,
55 const page_load_metrics::PageLoadExtraInfo& info) override;
56 void OnParseStart(const page_load_metrics::PageLoadTiming& timing,
57 const page_load_metrics::PageLoadExtraInfo& info) override;
58
59 private:
60 // Whether |web_contents| is showing an offline pages preview. Overridden in
61 // testing.
62 virtual bool IsOfflinePreview(content::WebContents* web_contents) const;
63
64 // Whether this page load was an offline pages preview.
65 bool is_offline_preview_;
66
67 DISALLOW_COPY_AND_ASSIGN(PreviewsPageLoadMetricsObserver);
68 };
69
70 } // namespace previews
71
72 #endif // CHROME_BROWSER_PAGE_LOAD_METRICS_OBSERVERS_PREVIEWS_PAGE_LOAD_METRICS _OBSERVER_H_
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698