Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(444)

Issue 2245143005: Move upgrade severity colors into NativeTheme. (Closed)

Created:
4 years, 4 months ago by Evan Stade
Modified:
4 years, 4 months ago
Reviewers:
tdanderson, sky
CC:
chromium-reviews, tfarina
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Move upgrade severity colors into NativeTheme. These will be shared in at least one more place (cros tray). BUG=638702 Committed: https://crrev.com/4a035aed30b8bbb7f59f3203ec180e252093ccef Cr-Commit-Position: refs/heads/master@{#412711}

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+34 lines, -4 lines) Patch
M chrome/browser/ui/libgtk2ui/native_theme_gtk2.cc View 1 chunk +6 lines, -0 lines 0 comments Download
M chrome/browser/ui/views/toolbar/app_menu_button.cc View 1 chunk +7 lines, -3 lines 0 comments Download
M ui/native_theme/common_theme.cc View 2 chunks +9 lines, -1 line 0 comments Download
M ui/native_theme/native_theme.h View 1 chunk +4 lines, -0 lines 0 comments Download
M ui/native_theme/native_theme_dark_aura.cc View 1 chunk +8 lines, -0 lines 2 comments Download

Messages

Total messages: 14 (6 generated)
Evan Stade
after https://codereview.chromium.org/2254933002/ lands (if it lands) you could do something similar for the system tray ...
4 years, 4 months ago (2016-08-17 18:07:20 UTC) #2
tdanderson
LGTM. You can reference BUG=638702 in this CL description and I will re-use that bug ...
4 years, 4 months ago (2016-08-17 19:44:58 UTC) #3
Evan Stade
https://codereview.chromium.org/2245143005/diff/1/ui/native_theme/native_theme_dark_aura.cc File ui/native_theme/native_theme_dark_aura.cc (right): https://codereview.chromium.org/2245143005/diff/1/ui/native_theme/native_theme_dark_aura.cc#newcode73 ui/native_theme/native_theme_dark_aura.cc:73: // Alert icons On 2016/08/17 19:44:58, tdanderson wrote: > ...
4 years, 4 months ago (2016-08-17 20:18:38 UTC) #4
Evan Stade
+sky for OWNERS
4 years, 4 months ago (2016-08-17 20:19:04 UTC) #7
sky
LGTM
4 years, 4 months ago (2016-08-17 20:44:04 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2245143005/1
4 years, 4 months ago (2016-08-17 23:38:50 UTC) #10
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 4 months ago (2016-08-18 01:10:34 UTC) #12
commit-bot: I haz the power
4 years, 4 months ago (2016-08-18 01:11:55 UTC) #14
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/4a035aed30b8bbb7f59f3203ec180e252093ccef
Cr-Commit-Position: refs/heads/master@{#412711}

Powered by Google App Engine
This is Rietveld 408576698