Make sure there is no crash on parsing empty manifest

Make sure there is no crash on parsing empty manifest

Changes match the logic in SourceHighlighter in the same file and will
result in UI showing message akin to 'No source file available'. This is fine
as already the same happens for other source files in bundled extensions.

BUG=627896
Committed: https://crrev.com/c4ae40ddcf81bddd262d56b9a7523466a4adba8f
Cr-Commit-Position: refs/heads/master@{#412556}

[Rafał Chłodnicki, 2016-08-17 13:27:01]

rchlodnicki@opera.com changed reviewers:
+ rdevlin.cronin@chromium.org

[Devlin, 2016-08-17 15:14:04]

lgtm, thanks for the patch!

https://codereview.chromium.org/2245143004/diff/20001/extensions/browser/file...
File extensions/browser/file_highlighter.cc (right):

https://codereview.chromium.org/2245143004/diff/20001/extensions/browser/file...
extensions/browser/file_highlighter.cc:117: start_ = start_ == std::string::npos
? contents_.size() : start_ + 1;
nit: since we reassign start_ in all cases, I think it's a little more readable
as
size_t value_begin /* not attached to this name */ = contents_.find('{');
start_ = value_begin == std::string::npos ? contents_.size() : value_begin + 1;

and ditto for end_.

[Rafał Chłodnicki, 2016-08-17 15:54:09]

The CQ bit was checked by rchlodnicki@opera.com

[commit-bot: I haz the power, 2016-08-17 15:54:23]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Rafał Chłodnicki, 2016-08-17 15:54:30]

https://codereview.chromium.org/2245143004/diff/20001/extensions/browser/file...
File extensions/browser/file_highlighter.cc (right):

https://codereview.chromium.org/2245143004/diff/20001/extensions/browser/file...
extensions/browser/file_highlighter.cc:117: start_ = start_ == std::string::npos
? contents_.size() : start_ + 1;
On 2016/08/17 15:14:03, Devlin wrote:
> nit: since we reassign start_ in all cases, I think it's a little more
readable
> as
> size_t value_begin /* not attached to this name */ = contents_.find('{');
> start_ = value_begin == std::string::npos ? contents_.size() : value_begin +
1;
> 
> and ditto for end_.

Let me just keep the current version. Proposed style would make things not fit
one line and thus readability would suffer slightly IMO. :)

[commit-bot: I haz the power, 2016-08-17 16:38:50]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-08-17 16:40:49]

Description was changed from

==========
Make sure there is no crash on parsing empty manifest

Changes match the logic in SourceHighlighter in the same file and will
result in UI showing message akin to 'No source file available'. This is fine
as already the same happens for other source files in bundled extensions.

BUG=627896
==========

to

==========
Make sure there is no crash on parsing empty manifest

Changes match the logic in SourceHighlighter in the same file and will
result in UI showing message akin to 'No source file available'. This is fine
as already the same happens for other source files in bundled extensions.

BUG=627896

Committed: https://crrev.com/c4ae40ddcf81bddd262d56b9a7523466a4adba8f
Cr-Commit-Position: refs/heads/master@{#412556}
==========

[commit-bot: I haz the power, 2016-08-17 16:40:50]

Patchset 2 (id:??) landed as
https://crrev.com/c4ae40ddcf81bddd262d56b9a7523466a4adba8f
Cr-Commit-Position: refs/heads/master@{#412556}