Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(585)

Issue 2245133005: Convert resource providers to use FileSource (Closed)

Created:
4 years, 4 months ago by Brian Wilkerson
Modified:
4 years, 4 months ago
Reviewers:
scheglov
CC:
reviews_dartlang.org
Base URL:
https://github.com/dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : Fix missed reference #

Unified diffs Side-by-side diffs Delta from patch set Stats (+21 lines, -120 lines) Patch
M pkg/analyzer/lib/file_system/memory_file_system.dart View 4 chunks +3 lines, -106 lines 0 comments Download
M pkg/analyzer/lib/file_system/physical_file_system.dart View 1 4 chunks +8 lines, -10 lines 0 comments Download
M pkg/analyzer/lib/src/generated/source_io.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/analyzer/lib/src/source/source_resource.dart View 2 chunks +9 lines, -3 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
Brian Wilkerson
4 years, 4 months ago (2016-08-16 22:08:20 UTC) #2
scheglov
LGTM
4 years, 4 months ago (2016-08-16 22:11:35 UTC) #3
Brian Wilkerson
4 years, 4 months ago (2016-08-17 03:11:03 UTC) #5
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as
910b2ba016be911cb6f7ff7f65e850482a9ce3ad (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698