Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(285)

Issue 2245133003: [style] Rename some enum values with 'k' prefix (Closed)

Created:
4 years, 4 months ago by adamk
Modified:
4 years, 4 months ago
Reviewers:
caitp, Dan Ehrenberg
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[style] Rename some enum values with 'k' prefix See https://google.github.io/styleguide/cppguide.html#Enumerator_Names Also rename "FunctionBody" to "FunctionBodyType" and move it inside Parser, which is the only place it's referenced. R=caitp@igalia.com, littledan@chromium.org Committed: https://crrev.com/7783d6fae7fdf34c3b1d942ad668b37d5b25eddb Cr-Commit-Position: refs/heads/master@{#38671}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+40 lines, -37 lines) Patch
M src/parsing/func-name-inferrer.h View 1 chunk +1 line, -1 line 0 comments Download
M src/parsing/parser.h View 3 chunks +4 lines, -2 lines 0 comments Download
M src/parsing/parser.cc View 5 chunks +9 lines, -7 lines 0 comments Download
M src/parsing/parser-base.h View 9 chunks +22 lines, -23 lines 0 comments Download
M src/parsing/preparser.h View 1 chunk +1 line, -1 line 0 comments Download
M src/parsing/preparser.cc View 1 chunk +3 lines, -3 lines 0 comments Download

Messages

Total messages: 11 (6 generated)
adamk
4 years, 4 months ago (2016-08-15 21:18:50 UTC) #1
Dan Ehrenberg
lgtm
4 years, 4 months ago (2016-08-16 02:29:28 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2245133003/1
4 years, 4 months ago (2016-08-16 22:29:02 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 4 months ago (2016-08-16 23:04:47 UTC) #9
commit-bot: I haz the power
4 years, 4 months ago (2016-08-16 23:05:18 UTC) #11
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/7783d6fae7fdf34c3b1d942ad668b37d5b25eddb
Cr-Commit-Position: refs/heads/master@{#38671}

Powered by Google App Engine
This is Rietveld 408576698