Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(18)

Issue 2245103004: Use DCHECK_IS_ON consistently in DatabaseTask. (Closed)

Created:
4 years, 4 months ago by skobes
Modified:
4 years, 4 months ago
Reviewers:
michaeln
CC:
chromium-reviews, blink-reviews, haraken
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Use DCHECK_IS_ON consistently in DatabaseTask. This fixes compile errors with blink_logging_always_on, introduced by http://crrev.com/411499. Also remove unused method hasSynchronizer(). BUG=596760 Committed: https://crrev.com/37b59c155f248d35040ceff1a3e8e893b5eb99c0 Cr-Commit-Position: refs/heads/master@{#412328}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -8 lines) Patch
M third_party/WebKit/Source/modules/webdatabase/DatabaseTask.h View 1 chunk +0 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/modules/webdatabase/DatabaseTask.cpp View 4 chunks +5 lines, -5 lines 0 comments Download

Messages

Total messages: 15 (9 generated)
skobes
4 years, 4 months ago (2016-08-16 19:52:13 UTC) #5
michaeln
lgtm
4 years, 4 months ago (2016-08-16 20:18:23 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2245103004/1
4 years, 4 months ago (2016-08-16 20:21:58 UTC) #10
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 4 months ago (2016-08-16 20:28:32 UTC) #12
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/37b59c155f248d35040ceff1a3e8e893b5eb99c0 Cr-Commit-Position: refs/heads/master@{#412328}
4 years, 4 months ago (2016-08-16 20:32:40 UTC) #14
tkent
4 years, 4 months ago (2016-08-16 23:02:17 UTC) #15
Message was sent while issue was closed.
Thank you for the fix!

Powered by Google App Engine
This is Rietveld 408576698