Issue 2245103002: [Merge to M53] Remove "Go Back/Forward" from keyboard overlay

Issue 2245103002: [Merge to M53] Remove "Go Back/Forward" from keyboard overlay (Closed)

Created:
4 years, 4 months ago by afakhry

Modified:
4 years, 4 months ago

Reviewers:
Lei Zhang, xiyuan

CC:
chromium-reviews, arv+watch_chromium.org, oshima+watch_chromium.org

Base URL:
https://chromium.googlesource.com/chromium/src.git@2785

Target Ref:
refs/pending/branch-heads/2785

Project:
chromium

Visibility:
Public.

[Merge to M53] Remove "Go Back/Forward" from keyboard overlay Only show these shortcuts if the finch experiment that turns them on is enabled. TBR=xiyuan@chromium.org,thestig@chromium.org BUG=633825 TEST=manually CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation;master.tryserver.chromium.linux:closure_compilation Review-Url: https://codereview.chromium.org/2206823004 Cr-Commit-Position: refs/heads/master@{#409900} (cherry picked from commit abbfa3e92777e0b55429cac3c880f12237732385) Committed: https://chromium.googlesource.com/chromium/src/+/e0bf06569f9627f5d28befef7d93e1984d9a44b3

Created: 4 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+25 lines, -6 lines)			Patch
M	chrome/browser/resources/chromeos/keyboard_overlay.js	View	1 chunk	+9 lines, -0 lines	0 comments	Download
M	chrome/browser/ui/browser_command_controller.cc	View	4 chunks	+3 lines, -6 lines	0 comments	Download
M	chrome/browser/ui/webui/chromeos/keyboard_overlay_ui.cc	View	2 chunks	+5 lines, -0 lines	0 comments	Download
M	chrome/common/chrome_features.h	View	1 chunk	+2 lines, -0 lines	0 comments	Download
M	chrome/common/chrome_features.cc	View	1 chunk	+6 lines, -0 lines	0 comments	Download

Total messages: 3 (2 generated)

afakhry

4 years, 4 months ago (2016-08-15 16:18:54 UTC) #3

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
e0bf06569f9627f5d28befef7d93e1984d9a44b3 (presubmit successful).