Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(809)

Unified Diff: runtime/vm/debugger.cc

Issue 22451002: - Make sure to not skip frames too early. (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/
Patch Set: Created 7 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: runtime/vm/debugger.cc
===================================================================
--- runtime/vm/debugger.cc (revision 25800)
+++ runtime/vm/debugger.cc (working copy)
@@ -949,10 +949,6 @@
code = frame->LookupDartCode();
ActivationFrame* activation =
new ActivationFrame(frame->pc(), frame->fp(), frame->sp(), code);
- // Check if frame is a debuggable function.
- if (!IsDebuggable(activation->function())) {
- continue;
- }
// If this activation frame called a closure, the function has
// saved its context before the call.
if ((callee_activation != NULL) &&
@@ -972,16 +968,19 @@
callee.ToFullyQualifiedCString(),
line, col);
}
- ASSERT(!ctx.IsNull());
}
if (optimized_frame_found || code.is_optimized()) {
// Set context to null, to avoid returning bad context variable values.
activation->SetContext(Context::Handle());
optimized_frame_found = true;
} else {
+ ASSERT(!ctx.IsNull());
activation->SetContext(ctx);
}
- stack_trace->AddActivation(activation);
+ // Check if frame is a debuggable function.
+ if (IsDebuggable(activation->function())) {
+ stack_trace->AddActivation(activation);
+ }
callee_activation = activation;
// Get caller's context if this function saved it on entry.
ctx = activation->GetSavedEntryContext(ctx);
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698