Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1250)

Unified Diff: masters/master.client.webrtc/master_mac_cfg.py

Issue 2245093002: WebRTC: Disable remote_run for webrtc/ios recipe (Closed) Base URL: https://chromium.googlesource.com/chromium/tools/build.git@master
Patch Set: Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | masters/master.tryserver.webrtc/master.cfg » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: masters/master.client.webrtc/master_mac_cfg.py
diff --git a/masters/master.client.webrtc/master_mac_cfg.py b/masters/master.client.webrtc/master_mac_cfg.py
index 3f589abc289064383f00cf11925e78de42eb029f..9877c5746c4670346bb3d6aaf04e0537156f56e6 100644
--- a/masters/master.client.webrtc/master_mac_cfg.py
+++ b/masters/master.client.webrtc/master_mac_cfg.py
@@ -4,6 +4,7 @@
from buildbot.schedulers.basic import SingleBranchScheduler
+from master.factory import annotator_factory
from master.factory import remote_run_factory
import master_site_config
@@ -19,6 +20,9 @@ def m_remote_run(recipe, **kwargs):
**kwargs)
+m_annotator = annotator_factory.AnnotatorFactory()
+
+
def Update(c):
c['schedulers'].extend([
SingleBranchScheduler(name='webrtc_mac_scheduler',
@@ -106,7 +110,10 @@ def Update(c):
c['builders'].extend([
{
'name': spec['name'],
- 'factory': m_remote_run(spec.get('recipe', 'webrtc/standalone')),
+ # remote_run is not working for the webrtc/ios recipe: crbug.com/637666.
+ 'factory': m_annotator.BaseFactory(spec['recipe'])
+ if 'recipe' in spec and spec['recipe'] == 'webrtc/ios'
+ else m_remote_run('webrtc/standalone'),
'notify_on_missing': True,
'category': spec.get('category', 'compile|testers'),
'slavebuilddir': spec['slavebuilddir'],
« no previous file with comments | « no previous file | masters/master.tryserver.webrtc/master.cfg » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698