[Sync] Clean up intra-sync DEPS significantly.

[Sync] Clean up intra-sync DEPS significantly.

This change is cleaning up some of the DEPS weirdness left over from
the directory structure shuffle that was done when sync was moved to a
component. See the bug for more context.

- fake_encryptor moved from test/ to base/ next to its base class.
- commit_queue moved from engine_impl/ to engine/ because of uses in
  driver/.
- sync_string_conversions moved from base/ to engine/ because of
  dependencies on core/.
- model_type_registry moved from sessions_impl/ to engine_impl/ because
  of dependencies on core/ and it having little to do with sessions.

BUG=637950
Committed: https://crrev.com/f727e610b5fdc72c17a0b62cc4793d1d72e542e8
Cr-Commit-Position: refs/heads/master@{#412099}

[maxbogue, 2016-08-15 21:52:03]

The CQ bit was checked by maxbogue@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-08-15 21:52:30]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[maxbogue, 2016-08-15 21:52:48]

maxbogue@chromium.org changed reviewers:
+ skym@chromium.org

[maxbogue, 2016-08-15 21:52:49]

Sky, PTAL!

[skym, 2016-08-15 22:17:53]

lgtm

https://codereview.chromium.org/2245073003/diff/1/components/sync/driver/ui_m...
File components/sync/driver/ui_model_type_controller_unittest.cc (right):

https://codereview.chromium.org/2245073003/diff/1/components/sync/driver/ui_m...
components/sync/driver/ui_model_type_controller_unittest.cc:48: class
NullCommitQueue : public syncer_v2::CommitQueue {
Can you delete this now?

https://codereview.chromium.org/2245073003/diff/1/components/sync/engine_impl...
File components/sync/engine_impl/DEPS (right):

https://codereview.chromium.org/2245073003/diff/1/components/sync/engine_impl...
components/sync/engine_impl/DEPS:3: # TODO(crbug.com/631271): core should be
split into driver/engine/api.
Should the 'c' in core be capitalized?

[commit-bot: I haz the power, 2016-08-15 22:25:01]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-15 22:25:02]

Dry run: Try jobs failed on following builders:
  mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[maxbogue, 2016-08-15 22:34:48]

The CQ bit was checked by maxbogue@chromium.org to run a CQ dry run

[maxbogue, 2016-08-15 22:35:07]

https://codereview.chromium.org/2245073003/diff/1/components/sync/driver/ui_m...
File components/sync/driver/ui_model_type_controller_unittest.cc (right):

https://codereview.chromium.org/2245073003/diff/1/components/sync/driver/ui_m...
components/sync/driver/ui_model_type_controller_unittest.cc:48: class
NullCommitQueue : public syncer_v2::CommitQueue {
On 2016/08/15 22:17:53, skym wrote:
> Can you delete this now?

Sadly the nullptr change below wasn't supposed to make it into this patch, so no
:( I was checking to see whether the NullCommitQueue was needed but it breaks
the tests.

https://codereview.chromium.org/2245073003/diff/1/components/sync/engine_impl...
File components/sync/engine_impl/DEPS (right):

https://codereview.chromium.org/2245073003/diff/1/components/sync/engine_impl...
components/sync/engine_impl/DEPS:3: # TODO(crbug.com/631271): core should be
split into driver/engine/api.
On 2016/08/15 22:17:53, skym wrote:
> Should the 'c' in core be capitalized?

¯\_(ツ)_/¯

Sure, why not. Done.

[commit-bot: I haz the power, 2016-08-15 22:35:20]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-15 23:24:47]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-15 23:24:48]

Dry run: This issue passed the CQ dry run.

[maxbogue, 2016-08-15 23:40:39]

The CQ bit was checked by maxbogue@chromium.org

[maxbogue, 2016-08-15 23:40:39]

The patchset sent to the CQ was uploaded after l-g-t-m from skym@chromium.org
Link to the patchset: https://codereview.chromium.org/2245073003/#ps20001
(title: "Address comments/fix test.")

[commit-bot: I haz the power, 2016-08-15 23:40:57]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-15 23:46:06]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-08-15 23:48:31]

Description was changed from

==========
[Sync] Clean up intra-sync DEPS significantly.

This change is cleaning up some of the DEPS weirdness left over from
the directory structure shuffle that was done when sync was moved to a
component. See the bug for more context.

- fake_encryptor moved from test/ to base/ next to its base class.
- commit_queue moved from engine_impl/ to engine/ because of uses in
  driver/.
- sync_string_conversions moved from base/ to engine/ because of
  dependencies on core/.
- model_type_registry moved from sessions_impl/ to engine_impl/ because
  of dependencies on core/ and it having little to do with sessions.

BUG=637950
==========

to

==========
[Sync] Clean up intra-sync DEPS significantly.

This change is cleaning up some of the DEPS weirdness left over from
the directory structure shuffle that was done when sync was moved to a
component. See the bug for more context.

- fake_encryptor moved from test/ to base/ next to its base class.
- commit_queue moved from engine_impl/ to engine/ because of uses in
  driver/.
- sync_string_conversions moved from base/ to engine/ because of
  dependencies on core/.
- model_type_registry moved from sessions_impl/ to engine_impl/ because
  of dependencies on core/ and it having little to do with sessions.

BUG=637950

Committed: https://crrev.com/f727e610b5fdc72c17a0b62cc4793d1d72e542e8
Cr-Commit-Position: refs/heads/master@{#412099}
==========

[commit-bot: I haz the power, 2016-08-15 23:48:32]

Patchset 2 (id:??) landed as
https://crrev.com/f727e610b5fdc72c17a0b62cc4793d1d72e542e8
Cr-Commit-Position: refs/heads/master@{#412099}