Chromium Code Reviews

Issue 2245073002: Fix handling of sdk path when building SDK summaries. (Closed)

Created:
4 years, 4 months ago by Paul Berry
Modified:
4 years, 4 months ago
Reviewers:
scheglov, Brian Wilkerson
CC:
reviews_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Fix handling of sdk path when building SDK summaries. This was inadvertently broken by c41427383b8dbe5fc49e0980bfb44c74f18d397b. R=brianwilkerson@google.com Committed: https://github.com/dart-lang/sdk/commit/ea1b511e236fcedd4eaf214ecfcffa52eb1334bb

Patch Set 1 #

Unified diffs Side-by-side diffs Stats (+2 lines, -2 lines)
M pkg/analyzer/lib/src/summary/summary_file_builder.dart View 1 chunk +2 lines, -2 lines 0 comments

Messages

Total messages: 5 (2 generated)
Paul Berry
4 years, 4 months ago (2016-08-15 14:00:39 UTC) #2
Brian Wilkerson
lgtm
4 years, 4 months ago (2016-08-15 14:19:54 UTC) #3
Paul Berry
4 years, 4 months ago (2016-08-15 14:29:40 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
ea1b511e236fcedd4eaf214ecfcffa52eb1334bb (presubmit successful).

Powered by Google App Engine