Revert of Refactoring button field and its type

Revert of Refactoring button field and its type (patchset #13 id:240001 of https://codereview.chromium.org/2227563003/ )

Reason for revert:
Webkit tests failing on WebKit Linux MSAN

https://build.chromium.org/p/chromium.webkit/builders/WebKit%20Linux%20MSAN/builds/11748

webkit_tests webkit_tests

unexpected_failures:
imported/wpt/pointerevents/pointerevent_pointertype_touch-manual.html
imported/wpt/pointerevents/pointerevent_touch-action-inherit_child-auto-child-none_touch-manual.html
imported/wpt/pointerevents/pointerevent_touch-action-auto-css_touch-manual.html
imported/wpt/pointerevents/pointerevent_touch-action-pan-x-pan-y-pan-y_touch-manual.html
imported/wpt/pointerevents/pointerevent_touch-action-none-css_touch-manual.html
imported/wpt/pointerevents/pointerevent_change-touch-action-onpointerdown_touch-manual.html
imported/wpt/pointerevents/pointerevent_touch-action-button-test_touch-manual.html
imported/wpt/pointerevents/pointerevent_pointerleave_touch-manual.html
imported/wpt/pointerevents/pointerevent_touch-action-pan-y-css_touch-manual.html
imported/wpt/pointerevents/pointerevent_pointerenter_nohover-manual.html
imported/wpt/pointerevents/pointerevent_touch-action-inherit_highest-parent-none_touch-manual.html
imported/wpt/pointerevents/pointerevent_pointerout_after_pointercancel_touch-manual.html
imported/wpt/pointerevents/pointerevent_pointerleave_after_pointerup_nohover-manual.html
imported/wpt/pointerevents/pointerevent_touch-action-svg-test_touch-manual.html
imported/wpt/pointerevents/pointerevent_pointerout_after_pointerup_nohover-manual.html
imported/wpt/pointerevents/pointerevent_pointerleave_after_pointercancel_touch-manual.html
imported/wpt/pointerevents/pointerevent_releasepointercapture_onpointercancel_touch-manual.html
imported/wpt/pointerevents/pointerevent_touch-action-pan-x-pan-y_touch-manual.html
imported/wpt/pointerevents/pointerevent_touch-action-inherit_parent-none_touch-manual.html
imported/wpt/pointerevents/pointerevent_touch-action-pan-x-css_touch-manual.html
imported/wpt/pointerevents/pointerevent_pointercancel_touch-manual.html
imported/wpt/pointerevents/pointerevent_touch-action-inherit_child-pan-x-child-pan-y_touch-manual.html
imported/wpt/pointerevents/pointerevent_touch-action-table-test_touch-manual.html
imported/wpt/pointerevents/pointerevent_touch-action-span-test_touch-manual.html
imported/wpt/pointerevents/pointerevent_touch-action-inherit_child-none_touch-manual.html
imported/wpt/pointerevents/pointerevent_touch-action-inherit_child-pan-x-child-pan-x_touch-manual.html

Original issue's description:
> Refactoring button field and its type
>
> - Remove m_button field from PlatformMouseEvent as
>     there was one in WebPointerProperties.
> - Remove duplicate PlatformMouseEvent::MouseButton
>     and WebScrollbarBehavior::Button enums and use
>     WebPointerProperties::Button enum instead.
> - Making WebPointerProperties::Button an enum class.
>
> - Also cleanup related target for pointerevents. The related target for all pointerevents (similar to mouseevent) should be null except for boundary events. So relatedTarget can be removed from some of the functions as they don't send boundary events.
>
> BUG=635670
> CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation
>
> TBR=pfeldman@chromium.org
>
> Committed: https://crrev.com/3acb734ff34a77e76228425d06952317c10e252b
> Cr-Commit-Position: refs/heads/master@{#412552}

TBR=pdr@chromium.org,bokan@chromium.org,dtapuska@chromium.org,mustaq@chromium.org,pfeldman@chromium.org,danakj@chromium.org,sky@chromium.org,thestig@chromium.org,nzolghadr@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
BUG=635670
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation

Committed: https://crrev.com/1c1f8f7a786bb441229143629a30048f187bf937
Cr-Commit-Position: refs/heads/master@{#412684}

[megjablon, 2016-08-17 19:20:34]

The CQ bit was checked by megjablon@chromium.org

[megjablon, 2016-08-17 19:20:35]

Created Revert of Refactoring button field and its type

[commit-bot: I haz the power, 2016-08-17 19:21:02]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-17 19:22:12]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-17 19:22:15]

Failed to apply patch for content/common/input/web_input_event_traits.cc:
While running git apply --index -3 -p1;
  error: content/common/input/web_input_event_traits.cc: does not exist in index

Patch:       content/common/input/web_input_event_traits.cc
Index: content/common/input/web_input_event_traits.cc
diff --git a/content/common/input/web_input_event_traits.cc
b/content/common/input/web_input_event_traits.cc
index
0ae3ece3edf4ddc581d4b961217cd747149ae8db..d88d85c3c8eacd3cf8b31d6709d5c3401050232a
100644
--- a/content/common/input/web_input_event_traits.cc
+++ b/content/common/input/web_input_event_traits.cc
@@ -35,7 +35,7 @@
   StringAppendF(result,
                 "{\n Button: %d\n Pos: (%d, %d)\n WindowPos: (%d, %d)\n"
                 " GlobalPos: (%d, %d)\n Movement: (%d, %d)\n Clicks: %d\n}",
-                static_cast<int>(event.button),
+                event.button,
                 event.x,
                 event.y,
                 event.windowX,

[mustaq, 2016-08-17 19:33:09]

Why are you suspecting crrev.com/2227563003? This shouldn't affect wpt tests
IMO.

[Navid Zolghadr, 2016-08-17 19:35:21]

On 2016/08/17 19:22:15, commit-bot: I haz the power wrote:
> Failed to apply patch for content/common/input/web_input_event_traits.cc:
> While running git apply --index -3 -p1;
>   error: content/common/input/web_input_event_traits.cc: does not exist in
index
> 
> Patch:       content/common/input/web_input_event_traits.cc
> Index: content/common/input/web_input_event_traits.cc
> diff --git a/content/common/input/web_input_event_traits.cc
> b/content/common/input/web_input_event_traits.cc
> index
>
0ae3ece3edf4ddc581d4b961217cd747149ae8db..d88d85c3c8eacd3cf8b31d6709d5c3401050232a
> 100644
> --- a/content/common/input/web_input_event_traits.cc
> +++ b/content/common/input/web_input_event_traits.cc
> @@ -35,7 +35,7 @@
>    StringAppendF(result,
>                  "{\n Button: %d\n Pos: (%d, %d)\n WindowPos: (%d, %d)\n"
>                  " GlobalPos: (%d, %d)\n Movement: (%d, %d)\n Clicks: %d\n}",
> -                static_cast<int>(event.button),
> +                event.button,
>                  event.x,
>                  event.y,
>                  event.windowX,

megjablon@ how did you find out this CL was the problem? Just curious as there
are some active developments on pointerevents and the other changes might have
caused this like this one:
https://codereview.chromium.org/2252683002/

How should I add that bot that is failing to a CL?

[megjablon, 2016-08-17 19:40:48]

On 2016/08/17 19:35:21, Navid Zolghadr wrote:
> On 2016/08/17 19:22:15, commit-bot: I haz the power wrote:
> > Failed to apply patch for content/common/input/web_input_event_traits.cc:
> > While running git apply --index -3 -p1;
> >   error: content/common/input/web_input_event_traits.cc: does not exist in
> index
> > 
> > Patch:       content/common/input/web_input_event_traits.cc
> > Index: content/common/input/web_input_event_traits.cc
> > diff --git a/content/common/input/web_input_event_traits.cc
> > b/content/common/input/web_input_event_traits.cc
> > index
> >
>
0ae3ece3edf4ddc581d4b961217cd747149ae8db..d88d85c3c8eacd3cf8b31d6709d5c3401050232a
> > 100644
> > --- a/content/common/input/web_input_event_traits.cc
> > +++ b/content/common/input/web_input_event_traits.cc
> > @@ -35,7 +35,7 @@
> >    StringAppendF(result,
> >                  "{\n Button: %d\n Pos: (%d, %d)\n WindowPos: (%d, %d)\n"
> >                  " GlobalPos: (%d, %d)\n Movement: (%d, %d)\n Clicks:
%d\n}",
> > -                static_cast<int>(event.button),
> > +                event.button,
> >                  event.x,
> >                  event.y,
> >                  event.windowX,
> 
> megjablon@ how did you find out this CL was the problem? Just curious as there
> are some active developments on pointerevents and the other changes might have
> caused this like this one:
> https://codereview.chromium.org/2252683002/
> 
> How should I add that bot that is failing to a CL?

The reason I suspected crrev.com/2227563003 was because it was the only change
to pointerevents in Build #11748 at the time that these tests started failing.
https://codereview.chromium.org/2252683002/ only landed 5 minutes ago and these
failures started a 1 and 45 minutes ago.

[megjablon, 2016-08-17 19:41:08]

The CQ bit was checked by megjablon@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-08-17 19:41:24]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-17 19:41:29]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-17 19:41:31]

Dry run: This issue passed the CQ dry run.

[Navid Zolghadr, 2016-08-17 19:47:50]

On 2016/08/17 19:40:48, megjablon wrote:
> On 2016/08/17 19:35:21, Navid Zolghadr wrote:
> > On 2016/08/17 19:22:15, commit-bot: I haz the power wrote:
> > > Failed to apply patch for content/common/input/web_input_event_traits.cc:
> > > While running git apply --index -3 -p1;
> > >   error: content/common/input/web_input_event_traits.cc: does not exist in
> > index
> > > 
> > > Patch:       content/common/input/web_input_event_traits.cc
> > > Index: content/common/input/web_input_event_traits.cc
> > > diff --git a/content/common/input/web_input_event_traits.cc
> > > b/content/common/input/web_input_event_traits.cc
> > > index
> > >
> >
>
0ae3ece3edf4ddc581d4b961217cd747149ae8db..d88d85c3c8eacd3cf8b31d6709d5c3401050232a
> > > 100644
> > > --- a/content/common/input/web_input_event_traits.cc
> > > +++ b/content/common/input/web_input_event_traits.cc
> > > @@ -35,7 +35,7 @@
> > >    StringAppendF(result,
> > >                  "{\n Button: %d\n Pos: (%d, %d)\n WindowPos: (%d, %d)\n"
> > >                  " GlobalPos: (%d, %d)\n Movement: (%d, %d)\n Clicks:
> %d\n}",
> > > -                static_cast<int>(event.button),
> > > +                event.button,
> > >                  event.x,
> > >                  event.y,
> > >                  event.windowX,
> > 
> > megjablon@ how did you find out this CL was the problem? Just curious as
there
> > are some active developments on pointerevents and the other changes might
have
> > caused this like this one:
> > https://codereview.chromium.org/2252683002/
> > 
> > How should I add that bot that is failing to a CL?
> 
> The reason I suspected crrev.com/2227563003 was because it was the only change
> to pointerevents in Build #11748 at the time that these tests started failing.
> https://codereview.chromium.org/2252683002/ only landed 5 minutes ago and
these
> failures started a 1 and 45 minutes ago.

How about how to add that bot to a CL?

[megjablon, 2016-08-17 19:56:01]

On 2016/08/17 19:47:50, Navid Zolghadr wrote:
> On 2016/08/17 19:40:48, megjablon wrote:
> > On 2016/08/17 19:35:21, Navid Zolghadr wrote:
> > > On 2016/08/17 19:22:15, commit-bot: I haz the power wrote:
> > > > Failed to apply patch for
content/common/input/web_input_event_traits.cc:
> > > > While running git apply --index -3 -p1;
> > > >   error: content/common/input/web_input_event_traits.cc: does not exist
in
> > > index
> > > > 
> > > > Patch:       content/common/input/web_input_event_traits.cc
> > > > Index: content/common/input/web_input_event_traits.cc
> > > > diff --git a/content/common/input/web_input_event_traits.cc
> > > > b/content/common/input/web_input_event_traits.cc
> > > > index
> > > >
> > >
> >
>
0ae3ece3edf4ddc581d4b961217cd747149ae8db..d88d85c3c8eacd3cf8b31d6709d5c3401050232a
> > > > 100644
> > > > --- a/content/common/input/web_input_event_traits.cc
> > > > +++ b/content/common/input/web_input_event_traits.cc
> > > > @@ -35,7 +35,7 @@
> > > >    StringAppendF(result,
> > > >                  "{\n Button: %d\n Pos: (%d, %d)\n WindowPos: (%d,
%d)\n"
> > > >                  " GlobalPos: (%d, %d)\n Movement: (%d, %d)\n Clicks:
> > %d\n}",
> > > > -                static_cast<int>(event.button),
> > > > +                event.button,
> > > >                  event.x,
> > > >                  event.y,
> > > >                  event.windowX,
> > > 
> > > megjablon@ how did you find out this CL was the problem? Just curious as
> there
> > > are some active developments on pointerevents and the other changes might
> have
> > > caused this like this one:
> > > https://codereview.chromium.org/2252683002/
> > > 
> > > How should I add that bot that is failing to a CL?
> > 
> > The reason I suspected crrev.com/2227563003 was because it was the only
change
> > to pointerevents in Build #11748 at the time that these tests started
failing.
> > https://codereview.chromium.org/2252683002/ only landed 5 minutes ago and
> these
> > failures started a 1 and 45 minutes ago.
> 
> How about how to add that bot to a CL?

I don't think there's a way to do that

[Navid Zolghadr, 2016-08-17 20:12:24]

Description was changed from

==========
Revert of Refactoring button field and its type (patchset #13 id:240001 of
https://codereview.chromium.org/2227563003/ )

Reason for revert:
Webkit tests failing on WebKit Linux MSAN

https://build.chromium.org/p/chromium.webkit/builders/WebKit%20Linux%20MSAN/b...

webkit_tests webkit_tests

unexpected_failures:
imported/wpt/pointerevents/pointerevent_pointertype_touch-manual.html
imported/wpt/pointerevents/pointerevent_touch-action-inherit_child-auto-child-none_touch-manual.html
imported/wpt/pointerevents/pointerevent_touch-action-auto-css_touch-manual.html
imported/wpt/pointerevents/pointerevent_touch-action-pan-x-pan-y-pan-y_touch-manual.html
imported/wpt/pointerevents/pointerevent_touch-action-none-css_touch-manual.html
imported/wpt/pointerevents/pointerevent_change-touch-action-onpointerdown_touch-manual.html
imported/wpt/pointerevents/pointerevent_touch-action-button-test_touch-manual.html
imported/wpt/pointerevents/pointerevent_pointerleave_touch-manual.html
imported/wpt/pointerevents/pointerevent_touch-action-pan-y-css_touch-manual.html
imported/wpt/pointerevents/pointerevent_pointerenter_nohover-manual.html
imported/wpt/pointerevents/pointerevent_touch-action-inherit_highest-parent-none_touch-manual.html
imported/wpt/pointerevents/pointerevent_pointerout_after_pointercancel_touch-manual.html
imported/wpt/pointerevents/pointerevent_pointerleave_after_pointerup_nohover-manual.html
imported/wpt/pointerevents/pointerevent_touch-action-svg-test_touch-manual.html
imported/wpt/pointerevents/pointerevent_pointerout_after_pointerup_nohover-manual.html
imported/wpt/pointerevents/pointerevent_pointerleave_after_pointercancel_touch-manual.html
imported/wpt/pointerevents/pointerevent_releasepointercapture_onpointercancel_touch-manual.html
imported/wpt/pointerevents/pointerevent_touch-action-pan-x-pan-y_touch-manual.html
imported/wpt/pointerevents/pointerevent_touch-action-inherit_parent-none_touch-manual.html
imported/wpt/pointerevents/pointerevent_touch-action-pan-x-css_touch-manual.html
imported/wpt/pointerevents/pointerevent_pointercancel_touch-manual.html
imported/wpt/pointerevents/pointerevent_touch-action-inherit_child-pan-x-child-pan-y_touch-manual.html
imported/wpt/pointerevents/pointerevent_touch-action-table-test_touch-manual.html
imported/wpt/pointerevents/pointerevent_touch-action-span-test_touch-manual.html
imported/wpt/pointerevents/pointerevent_touch-action-inherit_child-none_touch-manual.html
imported/wpt/pointerevents/pointerevent_touch-action-inherit_child-pan-x-child-pan-x_touch-manual.html

Original issue's description:
> Refactoring button field and its type
> 
> - Remove m_button field from PlatformMouseEvent as
>     there was one in WebPointerProperties.
> - Remove duplicate PlatformMouseEvent::MouseButton
>     and WebScrollbarBehavior::Button enums and use
>     WebPointerProperties::Button enum instead.
> - Making WebPointerProperties::Button an enum class.
> 
> - Also cleanup related target for pointerevents. The related target for all
pointerevents (similar to mouseevent) should be null except for boundary events.
So relatedTarget can be removed from some of the functions as they don't send
boundary events.
> 
> BUG=635670
> CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation
> 
> TBR=pfeldman@chromium.org
> 
> Committed: https://crrev.com/3acb734ff34a77e76228425d06952317c10e252b
> Cr-Commit-Position: refs/heads/master@{#412552}

TBR=pdr@chromium.org,bokan@chromium.org,dtapuska@chromium.org,mustaq@chromium...
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=635670
==========

to

==========
Revert of Refactoring button field and its type (patchset #13 id:240001 of
https://codereview.chromium.org/2227563003/ )

Reason for revert:
Webkit tests failing on WebKit Linux MSAN

https://build.chromium.org/p/chromium.webkit/builders/WebKit%20Linux%20MSAN/b...

webkit_tests webkit_tests

unexpected_failures:
imported/wpt/pointerevents/pointerevent_pointertype_touch-manual.html
imported/wpt/pointerevents/pointerevent_touch-action-inherit_child-auto-child-none_touch-manual.html
imported/wpt/pointerevents/pointerevent_touch-action-auto-css_touch-manual.html
imported/wpt/pointerevents/pointerevent_touch-action-pan-x-pan-y-pan-y_touch-manual.html
imported/wpt/pointerevents/pointerevent_touch-action-none-css_touch-manual.html
imported/wpt/pointerevents/pointerevent_change-touch-action-onpointerdown_touch-manual.html
imported/wpt/pointerevents/pointerevent_touch-action-button-test_touch-manual.html
imported/wpt/pointerevents/pointerevent_pointerleave_touch-manual.html
imported/wpt/pointerevents/pointerevent_touch-action-pan-y-css_touch-manual.html
imported/wpt/pointerevents/pointerevent_pointerenter_nohover-manual.html
imported/wpt/pointerevents/pointerevent_touch-action-inherit_highest-parent-none_touch-manual.html
imported/wpt/pointerevents/pointerevent_pointerout_after_pointercancel_touch-manual.html
imported/wpt/pointerevents/pointerevent_pointerleave_after_pointerup_nohover-manual.html
imported/wpt/pointerevents/pointerevent_touch-action-svg-test_touch-manual.html
imported/wpt/pointerevents/pointerevent_pointerout_after_pointerup_nohover-manual.html
imported/wpt/pointerevents/pointerevent_pointerleave_after_pointercancel_touch-manual.html
imported/wpt/pointerevents/pointerevent_releasepointercapture_onpointercancel_touch-manual.html
imported/wpt/pointerevents/pointerevent_touch-action-pan-x-pan-y_touch-manual.html
imported/wpt/pointerevents/pointerevent_touch-action-inherit_parent-none_touch-manual.html
imported/wpt/pointerevents/pointerevent_touch-action-pan-x-css_touch-manual.html
imported/wpt/pointerevents/pointerevent_pointercancel_touch-manual.html
imported/wpt/pointerevents/pointerevent_touch-action-inherit_child-pan-x-child-pan-y_touch-manual.html
imported/wpt/pointerevents/pointerevent_touch-action-table-test_touch-manual.html
imported/wpt/pointerevents/pointerevent_touch-action-span-test_touch-manual.html
imported/wpt/pointerevents/pointerevent_touch-action-inherit_child-none_touch-manual.html
imported/wpt/pointerevents/pointerevent_touch-action-inherit_child-pan-x-child-pan-x_touch-manual.html

Original issue's description:
> Refactoring button field and its type
> 
> - Remove m_button field from PlatformMouseEvent as
>     there was one in WebPointerProperties.
> - Remove duplicate PlatformMouseEvent::MouseButton
>     and WebScrollbarBehavior::Button enums and use
>     WebPointerProperties::Button enum instead.
> - Making WebPointerProperties::Button an enum class.
> 
> - Also cleanup related target for pointerevents. The related target for all
pointerevents (similar to mouseevent) should be null except for boundary events.
So relatedTarget can be removed from some of the functions as they don't send
boundary events.
> 
> BUG=635670
> CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation
> 
> TBR=pfeldman@chromium.org
> 
> Committed: https://crrev.com/3acb734ff34a77e76228425d06952317c10e252b
> Cr-Commit-Position: refs/heads/master@{#412552}

TBR=pdr@chromium.org,bokan@chromium.org,dtapuska@chromium.org,mustaq@chromium...
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=635670
==========

[Navid Zolghadr, 2016-08-17 20:16:57]

On 2016/08/17 19:56:01, megjablon wrote:
> On 2016/08/17 19:47:50, Navid Zolghadr wrote:
> > On 2016/08/17 19:40:48, megjablon wrote:
> > > On 2016/08/17 19:35:21, Navid Zolghadr wrote:
> > > > On 2016/08/17 19:22:15, commit-bot: I haz the power wrote:
> > > > > Failed to apply patch for
> content/common/input/web_input_event_traits.cc:
> > > > > While running git apply --index -3 -p1;
> > > > >   error: content/common/input/web_input_event_traits.cc: does not
exist
> in
> > > > index
> > > > > 
> > > > > Patch:       content/common/input/web_input_event_traits.cc
> > > > > Index: content/common/input/web_input_event_traits.cc
> > > > > diff --git a/content/common/input/web_input_event_traits.cc
> > > > > b/content/common/input/web_input_event_traits.cc
> > > > > index
> > > > >
> > > >
> > >
> >
>
0ae3ece3edf4ddc581d4b961217cd747149ae8db..d88d85c3c8eacd3cf8b31d6709d5c3401050232a
> > > > > 100644
> > > > > --- a/content/common/input/web_input_event_traits.cc
> > > > > +++ b/content/common/input/web_input_event_traits.cc
> > > > > @@ -35,7 +35,7 @@
> > > > >    StringAppendF(result,
> > > > >                  "{\n Button: %d\n Pos: (%d, %d)\n WindowPos: (%d,
> %d)\n"
> > > > >                  " GlobalPos: (%d, %d)\n Movement: (%d, %d)\n Clicks:
> > > %d\n}",
> > > > > -                static_cast<int>(event.button),
> > > > > +                event.button,
> > > > >                  event.x,
> > > > >                  event.y,
> > > > >                  event.windowX,
> > > > 
> > > > megjablon@ how did you find out this CL was the problem? Just curious as
> > there
> > > > are some active developments on pointerevents and the other changes
might
> > have
> > > > caused this like this one:
> > > > https://codereview.chromium.org/2252683002/
> > > > 
> > > > How should I add that bot that is failing to a CL?
> > > 
> > > The reason I suspected crrev.com/2227563003 was because it was the only
> change
> > > to pointerevents in Build #11748 at the time that these tests started
> failing.
> > > https://codereview.chromium.org/2252683002/ only landed 5 minutes ago and
> > these
> > > failures started a 1 and 45 minutes ago.
> > 
> > How about how to add that bot to a CL?
> 
> I don't think there's a way to do that

I'm trying to run linux_chromium_msan_rel_ng on one of my other changes which
can be applied to the tip of the tree to see whether that shows the problem or
not. In the mean time if you'd like to revert this change I believe you need to
find the other change that is conflicting with the revert and revert that one
first.

[mustaq, 2016-08-17 20:19:51]

On 2016/08/17 20:16:57, Navid Zolghadr wrote:
> On 2016/08/17 19:56:01, megjablon wrote:
> > On 2016/08/17 19:47:50, Navid Zolghadr wrote:
> > > On 2016/08/17 19:40:48, megjablon wrote:
> > > > On 2016/08/17 19:35:21, Navid Zolghadr wrote:
> > > > > On 2016/08/17 19:22:15, commit-bot: I haz the power wrote:
> > > > > > Failed to apply patch for
> > content/common/input/web_input_event_traits.cc:
> > > > > > While running git apply --index -3 -p1;
> > > > > >   error: content/common/input/web_input_event_traits.cc: does not
> exist
> > in
> > > > > index
> > > > > > 
> > > > > > Patch:       content/common/input/web_input_event_traits.cc
> > > > > > Index: content/common/input/web_input_event_traits.cc
> > > > > > diff --git a/content/common/input/web_input_event_traits.cc
> > > > > > b/content/common/input/web_input_event_traits.cc
> > > > > > index
> > > > > >
> > > > >
> > > >
> > >
> >
>
0ae3ece3edf4ddc581d4b961217cd747149ae8db..d88d85c3c8eacd3cf8b31d6709d5c3401050232a
> > > > > > 100644
> > > > > > --- a/content/common/input/web_input_event_traits.cc
> > > > > > +++ b/content/common/input/web_input_event_traits.cc
> > > > > > @@ -35,7 +35,7 @@
> > > > > >    StringAppendF(result,
> > > > > >                  "{\n Button: %d\n Pos: (%d, %d)\n WindowPos: (%d,
> > %d)\n"
> > > > > >                  " GlobalPos: (%d, %d)\n Movement: (%d, %d)\n
Clicks:
> > > > %d\n}",
> > > > > > -                static_cast<int>(event.button),
> > > > > > +                event.button,
> > > > > >                  event.x,
> > > > > >                  event.y,
> > > > > >                  event.windowX,
> > > > > 
> > > > > megjablon@ how did you find out this CL was the problem? Just curious
as
> > > there
> > > > > are some active developments on pointerevents and the other changes
> might
> > > have
> > > > > caused this like this one:
> > > > > https://codereview.chromium.org/2252683002/
> > > > > 
> > > > > How should I add that bot that is failing to a CL?
> > > > 
> > > > The reason I suspected crrev.com/2227563003 was because it was the only
> > change
> > > > to pointerevents in Build #11748 at the time that these tests started
> > failing.
> > > > https://codereview.chromium.org/2252683002/ only landed 5 minutes ago
and
> > > these
> > > > failures started a 1 and 45 minutes ago.
> > > 
> > > How about how to add that bot to a CL?
> > 
> > I don't think there's a way to do that
> 
> I'm trying to run linux_chromium_msan_rel_ng on one of my other changes which
> can be applied to the tip of the tree to see whether that shows the problem or
> not. In the mean time if you'd like to revert this change I believe you need
to
> find the other change that is conflicting with the revert and revert that one
> first.

I think just disabling the wpt tests & fixing the problem makes more sense than
doing all these reversals.

[megjablon, 2016-08-17 20:57:02]

Description was changed from

==========
Revert of Refactoring button field and its type (patchset #13 id:240001 of
https://codereview.chromium.org/2227563003/ )

Reason for revert:
Webkit tests failing on WebKit Linux MSAN

https://build.chromium.org/p/chromium.webkit/builders/WebKit%20Linux%20MSAN/b...

webkit_tests webkit_tests

unexpected_failures:
imported/wpt/pointerevents/pointerevent_pointertype_touch-manual.html
imported/wpt/pointerevents/pointerevent_touch-action-inherit_child-auto-child-none_touch-manual.html
imported/wpt/pointerevents/pointerevent_touch-action-auto-css_touch-manual.html
imported/wpt/pointerevents/pointerevent_touch-action-pan-x-pan-y-pan-y_touch-manual.html
imported/wpt/pointerevents/pointerevent_touch-action-none-css_touch-manual.html
imported/wpt/pointerevents/pointerevent_change-touch-action-onpointerdown_touch-manual.html
imported/wpt/pointerevents/pointerevent_touch-action-button-test_touch-manual.html
imported/wpt/pointerevents/pointerevent_pointerleave_touch-manual.html
imported/wpt/pointerevents/pointerevent_touch-action-pan-y-css_touch-manual.html
imported/wpt/pointerevents/pointerevent_pointerenter_nohover-manual.html
imported/wpt/pointerevents/pointerevent_touch-action-inherit_highest-parent-none_touch-manual.html
imported/wpt/pointerevents/pointerevent_pointerout_after_pointercancel_touch-manual.html
imported/wpt/pointerevents/pointerevent_pointerleave_after_pointerup_nohover-manual.html
imported/wpt/pointerevents/pointerevent_touch-action-svg-test_touch-manual.html
imported/wpt/pointerevents/pointerevent_pointerout_after_pointerup_nohover-manual.html
imported/wpt/pointerevents/pointerevent_pointerleave_after_pointercancel_touch-manual.html
imported/wpt/pointerevents/pointerevent_releasepointercapture_onpointercancel_touch-manual.html
imported/wpt/pointerevents/pointerevent_touch-action-pan-x-pan-y_touch-manual.html
imported/wpt/pointerevents/pointerevent_touch-action-inherit_parent-none_touch-manual.html
imported/wpt/pointerevents/pointerevent_touch-action-pan-x-css_touch-manual.html
imported/wpt/pointerevents/pointerevent_pointercancel_touch-manual.html
imported/wpt/pointerevents/pointerevent_touch-action-inherit_child-pan-x-child-pan-y_touch-manual.html
imported/wpt/pointerevents/pointerevent_touch-action-table-test_touch-manual.html
imported/wpt/pointerevents/pointerevent_touch-action-span-test_touch-manual.html
imported/wpt/pointerevents/pointerevent_touch-action-inherit_child-none_touch-manual.html
imported/wpt/pointerevents/pointerevent_touch-action-inherit_child-pan-x-child-pan-x_touch-manual.html

Original issue's description:
> Refactoring button field and its type
> 
> - Remove m_button field from PlatformMouseEvent as
>     there was one in WebPointerProperties.
> - Remove duplicate PlatformMouseEvent::MouseButton
>     and WebScrollbarBehavior::Button enums and use
>     WebPointerProperties::Button enum instead.
> - Making WebPointerProperties::Button an enum class.
> 
> - Also cleanup related target for pointerevents. The related target for all
pointerevents (similar to mouseevent) should be null except for boundary events.
So relatedTarget can be removed from some of the functions as they don't send
boundary events.
> 
> BUG=635670
> CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation
> 
> TBR=pfeldman@chromium.org
> 
> Committed: https://crrev.com/3acb734ff34a77e76228425d06952317c10e252b
> Cr-Commit-Position: refs/heads/master@{#412552}

TBR=pdr@chromium.org,bokan@chromium.org,dtapuska@chromium.org,mustaq@chromium...
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=635670
==========

to

==========
Revert of Refactoring button field and its type (patchset #13 id:240001 of
https://codereview.chromium.org/2227563003/ )

Reason for revert:
Webkit tests failing on WebKit Linux MSAN

https://build.chromium.org/p/chromium.webkit/builders/WebKit%20Linux%20MSAN/b...

webkit_tests webkit_tests

unexpected_failures:
imported/wpt/pointerevents/pointerevent_pointertype_touch-manual.html
imported/wpt/pointerevents/pointerevent_touch-action-inherit_child-auto-child-none_touch-manual.html
imported/wpt/pointerevents/pointerevent_touch-action-auto-css_touch-manual.html
imported/wpt/pointerevents/pointerevent_touch-action-pan-x-pan-y-pan-y_touch-manual.html
imported/wpt/pointerevents/pointerevent_touch-action-none-css_touch-manual.html
imported/wpt/pointerevents/pointerevent_change-touch-action-onpointerdown_touch-manual.html
imported/wpt/pointerevents/pointerevent_touch-action-button-test_touch-manual.html
imported/wpt/pointerevents/pointerevent_pointerleave_touch-manual.html
imported/wpt/pointerevents/pointerevent_touch-action-pan-y-css_touch-manual.html
imported/wpt/pointerevents/pointerevent_pointerenter_nohover-manual.html
imported/wpt/pointerevents/pointerevent_touch-action-inherit_highest-parent-none_touch-manual.html
imported/wpt/pointerevents/pointerevent_pointerout_after_pointercancel_touch-manual.html
imported/wpt/pointerevents/pointerevent_pointerleave_after_pointerup_nohover-manual.html
imported/wpt/pointerevents/pointerevent_touch-action-svg-test_touch-manual.html
imported/wpt/pointerevents/pointerevent_pointerout_after_pointerup_nohover-manual.html
imported/wpt/pointerevents/pointerevent_pointerleave_after_pointercancel_touch-manual.html
imported/wpt/pointerevents/pointerevent_releasepointercapture_onpointercancel_touch-manual.html
imported/wpt/pointerevents/pointerevent_touch-action-pan-x-pan-y_touch-manual.html
imported/wpt/pointerevents/pointerevent_touch-action-inherit_parent-none_touch-manual.html
imported/wpt/pointerevents/pointerevent_touch-action-pan-x-css_touch-manual.html
imported/wpt/pointerevents/pointerevent_pointercancel_touch-manual.html
imported/wpt/pointerevents/pointerevent_touch-action-inherit_child-pan-x-child-pan-y_touch-manual.html
imported/wpt/pointerevents/pointerevent_touch-action-table-test_touch-manual.html
imported/wpt/pointerevents/pointerevent_touch-action-span-test_touch-manual.html
imported/wpt/pointerevents/pointerevent_touch-action-inherit_child-none_touch-manual.html
imported/wpt/pointerevents/pointerevent_touch-action-inherit_child-pan-x-child-pan-x_touch-manual.html

Original issue's description:
> Refactoring button field and its type
> 
> - Remove m_button field from PlatformMouseEvent as
>     there was one in WebPointerProperties.
> - Remove duplicate PlatformMouseEvent::MouseButton
>     and WebScrollbarBehavior::Button enums and use
>     WebPointerProperties::Button enum instead.
> - Making WebPointerProperties::Button an enum class.
> 
> - Also cleanup related target for pointerevents. The related target for all
pointerevents (similar to mouseevent) should be null except for boundary events.
So relatedTarget can be removed from some of the functions as they don't send
boundary events.
> 
> BUG=635670
> CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation
> 
> TBR=pfeldman@chromium.org
> 
> Committed: https://crrev.com/3acb734ff34a77e76228425d06952317c10e252b
> Cr-Commit-Position: refs/heads/master@{#412552}

TBR=pdr@chromium.org,bokan@chromium.org,dtapuska@chromium.org,mustaq@chromium...
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=635670
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation
==========

[megjablon, 2016-08-17 20:58:01]

The CQ bit was checked by megjablon@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-08-17 20:58:25]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-17 20:58:33]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-17 20:58:34]

Dry run: This issue passed the CQ dry run.

[megjablon, 2016-08-17 21:01:32]

The CQ bit was checked by megjablon@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-08-17 21:02:00]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[megjablon, 2016-08-17 21:02:01]

Description was changed from

==========
Revert of Refactoring button field and its type (patchset #13 id:240001 of
https://codereview.chromium.org/2227563003/ )

Reason for revert:
Webkit tests failing on WebKit Linux MSAN

https://build.chromium.org/p/chromium.webkit/builders/WebKit%20Linux%20MSAN/b...

webkit_tests webkit_tests

unexpected_failures:
imported/wpt/pointerevents/pointerevent_pointertype_touch-manual.html
imported/wpt/pointerevents/pointerevent_touch-action-inherit_child-auto-child-none_touch-manual.html
imported/wpt/pointerevents/pointerevent_touch-action-auto-css_touch-manual.html
imported/wpt/pointerevents/pointerevent_touch-action-pan-x-pan-y-pan-y_touch-manual.html
imported/wpt/pointerevents/pointerevent_touch-action-none-css_touch-manual.html
imported/wpt/pointerevents/pointerevent_change-touch-action-onpointerdown_touch-manual.html
imported/wpt/pointerevents/pointerevent_touch-action-button-test_touch-manual.html
imported/wpt/pointerevents/pointerevent_pointerleave_touch-manual.html
imported/wpt/pointerevents/pointerevent_touch-action-pan-y-css_touch-manual.html
imported/wpt/pointerevents/pointerevent_pointerenter_nohover-manual.html
imported/wpt/pointerevents/pointerevent_touch-action-inherit_highest-parent-none_touch-manual.html
imported/wpt/pointerevents/pointerevent_pointerout_after_pointercancel_touch-manual.html
imported/wpt/pointerevents/pointerevent_pointerleave_after_pointerup_nohover-manual.html
imported/wpt/pointerevents/pointerevent_touch-action-svg-test_touch-manual.html
imported/wpt/pointerevents/pointerevent_pointerout_after_pointerup_nohover-manual.html
imported/wpt/pointerevents/pointerevent_pointerleave_after_pointercancel_touch-manual.html
imported/wpt/pointerevents/pointerevent_releasepointercapture_onpointercancel_touch-manual.html
imported/wpt/pointerevents/pointerevent_touch-action-pan-x-pan-y_touch-manual.html
imported/wpt/pointerevents/pointerevent_touch-action-inherit_parent-none_touch-manual.html
imported/wpt/pointerevents/pointerevent_touch-action-pan-x-css_touch-manual.html
imported/wpt/pointerevents/pointerevent_pointercancel_touch-manual.html
imported/wpt/pointerevents/pointerevent_touch-action-inherit_child-pan-x-child-pan-y_touch-manual.html
imported/wpt/pointerevents/pointerevent_touch-action-table-test_touch-manual.html
imported/wpt/pointerevents/pointerevent_touch-action-span-test_touch-manual.html
imported/wpt/pointerevents/pointerevent_touch-action-inherit_child-none_touch-manual.html
imported/wpt/pointerevents/pointerevent_touch-action-inherit_child-pan-x-child-pan-x_touch-manual.html

Original issue's description:
> Refactoring button field and its type
> 
> - Remove m_button field from PlatformMouseEvent as
>     there was one in WebPointerProperties.
> - Remove duplicate PlatformMouseEvent::MouseButton
>     and WebScrollbarBehavior::Button enums and use
>     WebPointerProperties::Button enum instead.
> - Making WebPointerProperties::Button an enum class.
> 
> - Also cleanup related target for pointerevents. The related target for all
pointerevents (similar to mouseevent) should be null except for boundary events.
So relatedTarget can be removed from some of the functions as they don't send
boundary events.
> 
> BUG=635670
> CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation
> 
> TBR=pfeldman@chromium.org
> 
> Committed: https://crrev.com/3acb734ff34a77e76228425d06952317c10e252b
> Cr-Commit-Position: refs/heads/master@{#412552}

TBR=pdr@chromium.org,bokan@chromium.org,dtapuska@chromium.org,mustaq@chromium...
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=635670
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation
==========

to

==========
Revert of Refactoring button field and its type (patchset #13 id:240001 of
https://codereview.chromium.org/2227563003/ )

Reason for revert:
Webkit tests failing on WebKit Linux MSAN

https://build.chromium.org/p/chromium.webkit/builders/WebKit%20Linux%20MSAN/b...

webkit_tests webkit_tests

unexpected_failures:
imported/wpt/pointerevents/pointerevent_pointertype_touch-manual.html
imported/wpt/pointerevents/pointerevent_touch-action-inherit_child-auto-child-none_touch-manual.html
imported/wpt/pointerevents/pointerevent_touch-action-auto-css_touch-manual.html
imported/wpt/pointerevents/pointerevent_touch-action-pan-x-pan-y-pan-y_touch-manual.html
imported/wpt/pointerevents/pointerevent_touch-action-none-css_touch-manual.html
imported/wpt/pointerevents/pointerevent_change-touch-action-onpointerdown_touch-manual.html
imported/wpt/pointerevents/pointerevent_touch-action-button-test_touch-manual.html
imported/wpt/pointerevents/pointerevent_pointerleave_touch-manual.html
imported/wpt/pointerevents/pointerevent_touch-action-pan-y-css_touch-manual.html
imported/wpt/pointerevents/pointerevent_pointerenter_nohover-manual.html
imported/wpt/pointerevents/pointerevent_touch-action-inherit_highest-parent-none_touch-manual.html
imported/wpt/pointerevents/pointerevent_pointerout_after_pointercancel_touch-manual.html
imported/wpt/pointerevents/pointerevent_pointerleave_after_pointerup_nohover-manual.html
imported/wpt/pointerevents/pointerevent_touch-action-svg-test_touch-manual.html
imported/wpt/pointerevents/pointerevent_pointerout_after_pointerup_nohover-manual.html
imported/wpt/pointerevents/pointerevent_pointerleave_after_pointercancel_touch-manual.html
imported/wpt/pointerevents/pointerevent_releasepointercapture_onpointercancel_touch-manual.html
imported/wpt/pointerevents/pointerevent_touch-action-pan-x-pan-y_touch-manual.html
imported/wpt/pointerevents/pointerevent_touch-action-inherit_parent-none_touch-manual.html
imported/wpt/pointerevents/pointerevent_touch-action-pan-x-css_touch-manual.html
imported/wpt/pointerevents/pointerevent_pointercancel_touch-manual.html
imported/wpt/pointerevents/pointerevent_touch-action-inherit_child-pan-x-child-pan-y_touch-manual.html
imported/wpt/pointerevents/pointerevent_touch-action-table-test_touch-manual.html
imported/wpt/pointerevents/pointerevent_touch-action-span-test_touch-manual.html
imported/wpt/pointerevents/pointerevent_touch-action-inherit_child-none_touch-manual.html
imported/wpt/pointerevents/pointerevent_touch-action-inherit_child-pan-x-child-pan-x_touch-manual.html

Original issue's description:
> Refactoring button field and its type
> 
> - Remove m_button field from PlatformMouseEvent as
>     there was one in WebPointerProperties.
> - Remove duplicate PlatformMouseEvent::MouseButton
>     and WebScrollbarBehavior::Button enums and use
>     WebPointerProperties::Button enum instead.
> - Making WebPointerProperties::Button an enum class.
> 
> - Also cleanup related target for pointerevents. The related target for all
pointerevents (similar to mouseevent) should be null except for boundary events.
So relatedTarget can be removed from some of the functions as they don't send
boundary events.
> 
> BUG=635670
> CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation
> 
> TBR=pfeldman@chromium.org
> 
> Committed: https://crrev.com/3acb734ff34a77e76228425d06952317c10e252b
> Cr-Commit-Position: refs/heads/master@{#412552}

TBR=pdr@chromium.org,bokan@chromium.org,dtapuska@chromium.org,mustaq@chromium...
# Skipping CQ checks because original CL landed less than 1 days ago.
BUG=635670
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation
==========

[commit-bot: I haz the power, 2016-08-17 21:02:04]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-17 21:02:05]

Dry run: This issue passed the CQ dry run.

[megjablon, 2016-08-17 21:02:07]

The CQ bit was checked by megjablon@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-08-17 21:02:43]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[megjablon, 2016-08-17 21:40:00]

The CQ bit was unchecked by megjablon@chromium.org

[megjablon, 2016-08-17 21:40:01]

The CQ bit was checked by megjablon@chromium.org

[commit-bot: I haz the power, 2016-08-17 21:40:14]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-17 23:14:27]

Description was changed from

==========
Revert of Refactoring button field and its type (patchset #13 id:240001 of
https://codereview.chromium.org/2227563003/ )

Reason for revert:
Webkit tests failing on WebKit Linux MSAN

https://build.chromium.org/p/chromium.webkit/builders/WebKit%20Linux%20MSAN/b...

webkit_tests webkit_tests

unexpected_failures:
imported/wpt/pointerevents/pointerevent_pointertype_touch-manual.html
imported/wpt/pointerevents/pointerevent_touch-action-inherit_child-auto-child-none_touch-manual.html
imported/wpt/pointerevents/pointerevent_touch-action-auto-css_touch-manual.html
imported/wpt/pointerevents/pointerevent_touch-action-pan-x-pan-y-pan-y_touch-manual.html
imported/wpt/pointerevents/pointerevent_touch-action-none-css_touch-manual.html
imported/wpt/pointerevents/pointerevent_change-touch-action-onpointerdown_touch-manual.html
imported/wpt/pointerevents/pointerevent_touch-action-button-test_touch-manual.html
imported/wpt/pointerevents/pointerevent_pointerleave_touch-manual.html
imported/wpt/pointerevents/pointerevent_touch-action-pan-y-css_touch-manual.html
imported/wpt/pointerevents/pointerevent_pointerenter_nohover-manual.html
imported/wpt/pointerevents/pointerevent_touch-action-inherit_highest-parent-none_touch-manual.html
imported/wpt/pointerevents/pointerevent_pointerout_after_pointercancel_touch-manual.html
imported/wpt/pointerevents/pointerevent_pointerleave_after_pointerup_nohover-manual.html
imported/wpt/pointerevents/pointerevent_touch-action-svg-test_touch-manual.html
imported/wpt/pointerevents/pointerevent_pointerout_after_pointerup_nohover-manual.html
imported/wpt/pointerevents/pointerevent_pointerleave_after_pointercancel_touch-manual.html
imported/wpt/pointerevents/pointerevent_releasepointercapture_onpointercancel_touch-manual.html
imported/wpt/pointerevents/pointerevent_touch-action-pan-x-pan-y_touch-manual.html
imported/wpt/pointerevents/pointerevent_touch-action-inherit_parent-none_touch-manual.html
imported/wpt/pointerevents/pointerevent_touch-action-pan-x-css_touch-manual.html
imported/wpt/pointerevents/pointerevent_pointercancel_touch-manual.html
imported/wpt/pointerevents/pointerevent_touch-action-inherit_child-pan-x-child-pan-y_touch-manual.html
imported/wpt/pointerevents/pointerevent_touch-action-table-test_touch-manual.html
imported/wpt/pointerevents/pointerevent_touch-action-span-test_touch-manual.html
imported/wpt/pointerevents/pointerevent_touch-action-inherit_child-none_touch-manual.html
imported/wpt/pointerevents/pointerevent_touch-action-inherit_child-pan-x-child-pan-x_touch-manual.html

Original issue's description:
> Refactoring button field and its type
> 
> - Remove m_button field from PlatformMouseEvent as
>     there was one in WebPointerProperties.
> - Remove duplicate PlatformMouseEvent::MouseButton
>     and WebScrollbarBehavior::Button enums and use
>     WebPointerProperties::Button enum instead.
> - Making WebPointerProperties::Button an enum class.
> 
> - Also cleanup related target for pointerevents. The related target for all
pointerevents (similar to mouseevent) should be null except for boundary events.
So relatedTarget can be removed from some of the functions as they don't send
boundary events.
> 
> BUG=635670
> CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation
> 
> TBR=pfeldman@chromium.org
> 
> Committed: https://crrev.com/3acb734ff34a77e76228425d06952317c10e252b
> Cr-Commit-Position: refs/heads/master@{#412552}

TBR=pdr@chromium.org,bokan@chromium.org,dtapuska@chromium.org,mustaq@chromium...
# Skipping CQ checks because original CL landed less than 1 days ago.
BUG=635670
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation
==========

to

==========
Revert of Refactoring button field and its type (patchset #13 id:240001 of
https://codereview.chromium.org/2227563003/ )

Reason for revert:
Webkit tests failing on WebKit Linux MSAN

https://build.chromium.org/p/chromium.webkit/builders/WebKit%20Linux%20MSAN/b...

webkit_tests webkit_tests

unexpected_failures:
imported/wpt/pointerevents/pointerevent_pointertype_touch-manual.html
imported/wpt/pointerevents/pointerevent_touch-action-inherit_child-auto-child-none_touch-manual.html
imported/wpt/pointerevents/pointerevent_touch-action-auto-css_touch-manual.html
imported/wpt/pointerevents/pointerevent_touch-action-pan-x-pan-y-pan-y_touch-manual.html
imported/wpt/pointerevents/pointerevent_touch-action-none-css_touch-manual.html
imported/wpt/pointerevents/pointerevent_change-touch-action-onpointerdown_touch-manual.html
imported/wpt/pointerevents/pointerevent_touch-action-button-test_touch-manual.html
imported/wpt/pointerevents/pointerevent_pointerleave_touch-manual.html
imported/wpt/pointerevents/pointerevent_touch-action-pan-y-css_touch-manual.html
imported/wpt/pointerevents/pointerevent_pointerenter_nohover-manual.html
imported/wpt/pointerevents/pointerevent_touch-action-inherit_highest-parent-none_touch-manual.html
imported/wpt/pointerevents/pointerevent_pointerout_after_pointercancel_touch-manual.html
imported/wpt/pointerevents/pointerevent_pointerleave_after_pointerup_nohover-manual.html
imported/wpt/pointerevents/pointerevent_touch-action-svg-test_touch-manual.html
imported/wpt/pointerevents/pointerevent_pointerout_after_pointerup_nohover-manual.html
imported/wpt/pointerevents/pointerevent_pointerleave_after_pointercancel_touch-manual.html
imported/wpt/pointerevents/pointerevent_releasepointercapture_onpointercancel_touch-manual.html
imported/wpt/pointerevents/pointerevent_touch-action-pan-x-pan-y_touch-manual.html
imported/wpt/pointerevents/pointerevent_touch-action-inherit_parent-none_touch-manual.html
imported/wpt/pointerevents/pointerevent_touch-action-pan-x-css_touch-manual.html
imported/wpt/pointerevents/pointerevent_pointercancel_touch-manual.html
imported/wpt/pointerevents/pointerevent_touch-action-inherit_child-pan-x-child-pan-y_touch-manual.html
imported/wpt/pointerevents/pointerevent_touch-action-table-test_touch-manual.html
imported/wpt/pointerevents/pointerevent_touch-action-span-test_touch-manual.html
imported/wpt/pointerevents/pointerevent_touch-action-inherit_child-none_touch-manual.html
imported/wpt/pointerevents/pointerevent_touch-action-inherit_child-pan-x-child-pan-x_touch-manual.html

Original issue's description:
> Refactoring button field and its type
> 
> - Remove m_button field from PlatformMouseEvent as
>     there was one in WebPointerProperties.
> - Remove duplicate PlatformMouseEvent::MouseButton
>     and WebScrollbarBehavior::Button enums and use
>     WebPointerProperties::Button enum instead.
> - Making WebPointerProperties::Button an enum class.
> 
> - Also cleanup related target for pointerevents. The related target for all
pointerevents (similar to mouseevent) should be null except for boundary events.
So relatedTarget can be removed from some of the functions as they don't send
boundary events.
> 
> BUG=635670
> CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation
> 
> TBR=pfeldman@chromium.org
> 
> Committed: https://crrev.com/3acb734ff34a77e76228425d06952317c10e252b
> Cr-Commit-Position: refs/heads/master@{#412552}

TBR=pdr@chromium.org,bokan@chromium.org,dtapuska@chromium.org,mustaq@chromium...
# Skipping CQ checks because original CL landed less than 1 days ago.
BUG=635670
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation
==========

[commit-bot: I haz the power, 2016-08-17 23:14:29]

Committed patchset #2 (id:300001)

[commit-bot: I haz the power, 2016-08-17 23:19:49]

Description was changed from

==========
Revert of Refactoring button field and its type (patchset #13 id:240001 of
https://codereview.chromium.org/2227563003/ )

Reason for revert:
Webkit tests failing on WebKit Linux MSAN

https://build.chromium.org/p/chromium.webkit/builders/WebKit%20Linux%20MSAN/b...

webkit_tests webkit_tests

unexpected_failures:
imported/wpt/pointerevents/pointerevent_pointertype_touch-manual.html
imported/wpt/pointerevents/pointerevent_touch-action-inherit_child-auto-child-none_touch-manual.html
imported/wpt/pointerevents/pointerevent_touch-action-auto-css_touch-manual.html
imported/wpt/pointerevents/pointerevent_touch-action-pan-x-pan-y-pan-y_touch-manual.html
imported/wpt/pointerevents/pointerevent_touch-action-none-css_touch-manual.html
imported/wpt/pointerevents/pointerevent_change-touch-action-onpointerdown_touch-manual.html
imported/wpt/pointerevents/pointerevent_touch-action-button-test_touch-manual.html
imported/wpt/pointerevents/pointerevent_pointerleave_touch-manual.html
imported/wpt/pointerevents/pointerevent_touch-action-pan-y-css_touch-manual.html
imported/wpt/pointerevents/pointerevent_pointerenter_nohover-manual.html
imported/wpt/pointerevents/pointerevent_touch-action-inherit_highest-parent-none_touch-manual.html
imported/wpt/pointerevents/pointerevent_pointerout_after_pointercancel_touch-manual.html
imported/wpt/pointerevents/pointerevent_pointerleave_after_pointerup_nohover-manual.html
imported/wpt/pointerevents/pointerevent_touch-action-svg-test_touch-manual.html
imported/wpt/pointerevents/pointerevent_pointerout_after_pointerup_nohover-manual.html
imported/wpt/pointerevents/pointerevent_pointerleave_after_pointercancel_touch-manual.html
imported/wpt/pointerevents/pointerevent_releasepointercapture_onpointercancel_touch-manual.html
imported/wpt/pointerevents/pointerevent_touch-action-pan-x-pan-y_touch-manual.html
imported/wpt/pointerevents/pointerevent_touch-action-inherit_parent-none_touch-manual.html
imported/wpt/pointerevents/pointerevent_touch-action-pan-x-css_touch-manual.html
imported/wpt/pointerevents/pointerevent_pointercancel_touch-manual.html
imported/wpt/pointerevents/pointerevent_touch-action-inherit_child-pan-x-child-pan-y_touch-manual.html
imported/wpt/pointerevents/pointerevent_touch-action-table-test_touch-manual.html
imported/wpt/pointerevents/pointerevent_touch-action-span-test_touch-manual.html
imported/wpt/pointerevents/pointerevent_touch-action-inherit_child-none_touch-manual.html
imported/wpt/pointerevents/pointerevent_touch-action-inherit_child-pan-x-child-pan-x_touch-manual.html

Original issue's description:
> Refactoring button field and its type
> 
> - Remove m_button field from PlatformMouseEvent as
>     there was one in WebPointerProperties.
> - Remove duplicate PlatformMouseEvent::MouseButton
>     and WebScrollbarBehavior::Button enums and use
>     WebPointerProperties::Button enum instead.
> - Making WebPointerProperties::Button an enum class.
> 
> - Also cleanup related target for pointerevents. The related target for all
pointerevents (similar to mouseevent) should be null except for boundary events.
So relatedTarget can be removed from some of the functions as they don't send
boundary events.
> 
> BUG=635670
> CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation
> 
> TBR=pfeldman@chromium.org
> 
> Committed: https://crrev.com/3acb734ff34a77e76228425d06952317c10e252b
> Cr-Commit-Position: refs/heads/master@{#412552}

TBR=pdr@chromium.org,bokan@chromium.org,dtapuska@chromium.org,mustaq@chromium...
# Skipping CQ checks because original CL landed less than 1 days ago.
BUG=635670
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation
==========

to

==========
Revert of Refactoring button field and its type (patchset #13 id:240001 of
https://codereview.chromium.org/2227563003/ )

Reason for revert:
Webkit tests failing on WebKit Linux MSAN

https://build.chromium.org/p/chromium.webkit/builders/WebKit%20Linux%20MSAN/b...

webkit_tests webkit_tests

unexpected_failures:
imported/wpt/pointerevents/pointerevent_pointertype_touch-manual.html
imported/wpt/pointerevents/pointerevent_touch-action-inherit_child-auto-child-none_touch-manual.html
imported/wpt/pointerevents/pointerevent_touch-action-auto-css_touch-manual.html
imported/wpt/pointerevents/pointerevent_touch-action-pan-x-pan-y-pan-y_touch-manual.html
imported/wpt/pointerevents/pointerevent_touch-action-none-css_touch-manual.html
imported/wpt/pointerevents/pointerevent_change-touch-action-onpointerdown_touch-manual.html
imported/wpt/pointerevents/pointerevent_touch-action-button-test_touch-manual.html
imported/wpt/pointerevents/pointerevent_pointerleave_touch-manual.html
imported/wpt/pointerevents/pointerevent_touch-action-pan-y-css_touch-manual.html
imported/wpt/pointerevents/pointerevent_pointerenter_nohover-manual.html
imported/wpt/pointerevents/pointerevent_touch-action-inherit_highest-parent-none_touch-manual.html
imported/wpt/pointerevents/pointerevent_pointerout_after_pointercancel_touch-manual.html
imported/wpt/pointerevents/pointerevent_pointerleave_after_pointerup_nohover-manual.html
imported/wpt/pointerevents/pointerevent_touch-action-svg-test_touch-manual.html
imported/wpt/pointerevents/pointerevent_pointerout_after_pointerup_nohover-manual.html
imported/wpt/pointerevents/pointerevent_pointerleave_after_pointercancel_touch-manual.html
imported/wpt/pointerevents/pointerevent_releasepointercapture_onpointercancel_touch-manual.html
imported/wpt/pointerevents/pointerevent_touch-action-pan-x-pan-y_touch-manual.html
imported/wpt/pointerevents/pointerevent_touch-action-inherit_parent-none_touch-manual.html
imported/wpt/pointerevents/pointerevent_touch-action-pan-x-css_touch-manual.html
imported/wpt/pointerevents/pointerevent_pointercancel_touch-manual.html
imported/wpt/pointerevents/pointerevent_touch-action-inherit_child-pan-x-child-pan-y_touch-manual.html
imported/wpt/pointerevents/pointerevent_touch-action-table-test_touch-manual.html
imported/wpt/pointerevents/pointerevent_touch-action-span-test_touch-manual.html
imported/wpt/pointerevents/pointerevent_touch-action-inherit_child-none_touch-manual.html
imported/wpt/pointerevents/pointerevent_touch-action-inherit_child-pan-x-child-pan-x_touch-manual.html

Original issue's description:
> Refactoring button field and its type
>
> - Remove m_button field from PlatformMouseEvent as
>     there was one in WebPointerProperties.
> - Remove duplicate PlatformMouseEvent::MouseButton
>     and WebScrollbarBehavior::Button enums and use
>     WebPointerProperties::Button enum instead.
> - Making WebPointerProperties::Button an enum class.
>
> - Also cleanup related target for pointerevents. The related target for all
pointerevents (similar to mouseevent) should be null except for boundary events.
So relatedTarget can be removed from some of the functions as they don't send
boundary events.
>
> BUG=635670
> CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation
>
> TBR=pfeldman@chromium.org
>
> Committed: https://crrev.com/3acb734ff34a77e76228425d06952317c10e252b
> Cr-Commit-Position: refs/heads/master@{#412552}

TBR=pdr@chromium.org,bokan@chromium.org,dtapuska@chromium.org,mustaq@chromium...
# Skipping CQ checks because original CL landed less than 1 days ago.
BUG=635670
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation

Committed: https://crrev.com/1c1f8f7a786bb441229143629a30048f187bf937
Cr-Commit-Position: refs/heads/master@{#412684}
==========

[commit-bot: I haz the power, 2016-08-17 23:19:51]

Patchset 2 (id:??) landed as
https://crrev.com/1c1f8f7a786bb441229143629a30048f187bf937
Cr-Commit-Position: refs/heads/master@{#412684}