Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(910)

Unified Diff: content/browser/service_worker/service_worker_request_handler.cc

Issue 2245063003: ServiceWorker: Call SyncMatchingRegistration when document_url is changed (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Updated comments Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/service_worker/service_worker_request_handler.cc
diff --git a/content/browser/service_worker/service_worker_request_handler.cc b/content/browser/service_worker/service_worker_request_handler.cc
index 980fd03d46b7c33995ee730ee2f07ab52db74fd1..32f4a689c5663b4a5fbb41050373aa7e4c613b81 100644
--- a/content/browser/service_worker/service_worker_request_handler.cc
+++ b/content/browser/service_worker/service_worker_request_handler.cc
@@ -71,9 +71,6 @@ void FinalizeHandlerInitialization(
if (ServiceWorkerUtils::IsMainResourceType(resource_type)) {
provider_host->SetDocumentUrl(net::SimplifyUrlForRequest(request->url()));
provider_host->SetTopmostFrameUrl(request->first_party_for_cookies());
- // A page load with skip_service_worker should be triggered by
- // shift-reload, so retain all live matching registrations.
- provider_host->AddAllMatchingRegistrations();
}
return;
}

Powered by Google App Engine
This is Rietveld 408576698