Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(478)

Unified Diff: content/browser/service_worker/service_worker_provider_host.h

Issue 2245063003: ServiceWorker: Call SyncMatchingRegistration when document_url is changed (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Updated comments Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | content/browser/service_worker/service_worker_provider_host.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/browser/service_worker/service_worker_provider_host.h
diff --git a/content/browser/service_worker/service_worker_provider_host.h b/content/browser/service_worker/service_worker_provider_host.h
index 0ca74533ce6542014a60acf86db9e28ffc29aace..a47eaa099efeb931ab7447ea5b3fe4bb67df1777 100644
--- a/content/browser/service_worker/service_worker_provider_host.h
+++ b/content/browser/service_worker/service_worker_provider_host.h
@@ -137,6 +137,9 @@ class CONTENT_EXPORT ServiceWorkerProviderHost
return running_hosted_version_.get();
}
+ // Sets the |document_url_|. When this object is for a client,
+ // |matching_registrations_| gets also updated to ensure that |document_url_|
+ // is in scope of all |matching_registrations_|.
void SetDocumentUrl(const GURL& url);
const GURL& document_url() const { return document_url_; }
@@ -246,9 +249,6 @@ class CONTENT_EXPORT ServiceWorkerProviderHost
void AddMatchingRegistration(ServiceWorkerRegistration* registration);
void RemoveMatchingRegistration(ServiceWorkerRegistration* registration);
- // Add matched registrations for document generated by shift-reload.
- void AddAllMatchingRegistrations();
-
// An optimized implementation of [[Match Service Worker Registration]]
// for current document.
ServiceWorkerRegistration* MatchRegistration() const;
@@ -311,6 +311,12 @@ class CONTENT_EXPORT ServiceWorkerProviderHost
void SendAssociateRegistrationMessage();
+ // Syncs matching registrations with live registrations.
+ void SyncMatchingRegistrations();
+
+ // Discards all references to matching registrations.
+ void RemoveAllMatchingRegistrations();
+
// Increase/decrease this host's process reference for |pattern|.
void IncreaseProcessReference(const GURL& pattern);
void DecreaseProcessReference(const GURL& pattern);
« no previous file with comments | « no previous file | content/browser/service_worker/service_worker_provider_host.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698