cc/trees/layer_tree_host.cc - Issue 2245053002: Fix UB with LayerTreeImpl::PassSwapPromises usage

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: cc/trees/layer_tree_host.cc

Issue 2245053002: Fix UB with LayerTreeImpl::PassSwapPromises usage (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Use std::vector::clear instead Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: cc/trees/layer_tree_host.cc

diff --git a/cc/trees/layer_tree_host.cc b/cc/trees/layer_tree_host.cc

index 8e0493a8c1af61f5f87ab840f4ae5be1a468df18..db7dc824fd8148a519dc6e80504b3c981faadefe 100644

--- a/cc/trees/layer_tree_host.cc

+++ b/cc/trees/layer_tree_host.cc

@@ -512,6 +512,7 @@ void LayerTreeHost::FinishCommitOnImplThread(LayerTreeHostImpl* host_impl) {

sync_tree->elastic_overscroll()->PushPendingToActive();

sync_tree->PassSwapPromises(std::move(swap_promise_list_));

+ swap_promise_list_.clear();

sync_tree->set_top_controls_shrink_blink_size(

top_controls_shrink_blink_size_);

« no previous file with comments | « no previous file | cc/trees/layer_tree_impl.cc » ('j') | no next file with comments »