Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1363)

Unified Diff: content/renderer/media/audio_track_recorder.cc

Issue 2245043002: Remove unnecessary DCHECK(encoder_thread_.IsRunning()) from AudioRecorder (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/renderer/media/audio_track_recorder.cc
diff --git a/content/renderer/media/audio_track_recorder.cc b/content/renderer/media/audio_track_recorder.cc
index 253c7d9968a73da27b4f8d1482defe5924016877..80df03701a99e22d9ff4f2b0f48849ee26ea3d5c 100644
--- a/content/renderer/media/audio_track_recorder.cc
+++ b/content/renderer/media/audio_track_recorder.cc
@@ -295,7 +295,6 @@ AudioTrackRecorder::AudioTrackRecorder(
// Start the |encoder_thread_|. From this point on, |encoder_| should work
// only on |encoder_thread_|, as enforced by DCHECKs.
- DCHECK(!encoder_thread_.IsRunning());
encoder_thread_.Start();
// Connect the source provider to the track as a sink.
@@ -308,7 +307,6 @@ AudioTrackRecorder::~AudioTrackRecorder() {
}
void AudioTrackRecorder::OnSetFormat(const media::AudioParameters& params) {
- DCHECK(encoder_thread_.IsRunning());
// If the source is restarted, might have changed to another capture thread.
capture_thread_checker_.DetachFromThread();
DCHECK(capture_thread_checker_.CalledOnValidThread());
@@ -319,7 +317,6 @@ void AudioTrackRecorder::OnSetFormat(const media::AudioParameters& params) {
void AudioTrackRecorder::OnData(const media::AudioBus& audio_bus,
base::TimeTicks capture_time) {
- DCHECK(encoder_thread_.IsRunning());
DCHECK(capture_thread_checker_.CalledOnValidThread());
DCHECK(!capture_time.is_null());
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698