Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2564)

Issue 2245043002: Remove unnecessary DCHECK(encoder_thread_.IsRunning()) from AudioRecorder (Closed)

Created:
4 years, 4 months ago by perkj_chrome
Modified:
4 years, 4 months ago
Reviewers:
Niklas Enbom
CC:
chromium-reviews, posciak+watch_chromium.org, mlamouri+watch-content_chromium.org, jam, darin-cc_chromium.org, feature-media-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove unnecessary DCHECK(encoder_thread_.IsRunning()) from AudioRecorder. Calling encoder_thread_.IsRunning() is apparently illegal from another sequence than the sequence/thread that started the thread. BUG=629139 Committed: https://crrev.com/c3c5c2b2f032d44429ed6cc88bcd125c20ed9e10 Cr-Commit-Position: refs/heads/master@{#412187}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -3 lines) Patch
M content/renderer/media/audio_track_recorder.cc View 3 chunks +0 lines, -3 lines 0 comments Download

Messages

Total messages: 14 (9 generated)
perkj_chrome
please?
4 years, 4 months ago (2016-08-15 09:35:26 UTC) #4
Niklas Enbom
lgtm, but maybe description should be updated since the call to Thread::IsRunning is illegal and ...
4 years, 4 months ago (2016-08-15 18:58:59 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2245043002/1
4 years, 4 months ago (2016-08-16 07:25:20 UTC) #10
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 4 months ago (2016-08-16 07:28:53 UTC) #12
commit-bot: I haz the power
4 years, 4 months ago (2016-08-16 07:30:44 UTC) #14
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/c3c5c2b2f032d44429ed6cc88bcd125c20ed9e10
Cr-Commit-Position: refs/heads/master@{#412187}

Powered by Google App Engine
This is Rietveld 408576698