Issue 22450005: remove include from the header paths

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 22450005: remove include from the header paths (Closed)

Created:
7 years, 4 months ago by djsollen

Modified:
7 years, 4 months ago

Reviewers:
tfarina, Torne, robertphillips

CC:
skia-review_googlegroups.com

Base URL:
https://skia.googlecode.com/svn/trunk

Visibility:
Public.

More Reviews

Description

remove include from the header paths R=robertphillips@google.com, torne@chromium.org Committed: https://code.google.com/p/skia/source/detail?r=10664

Patch Set 1 #

Total comments: 1

Created: 7 years, 4 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+298 lines, -298 lines)			Patch
	M	gyp/public_headers.gypi	View		1 chunk	+298 lines, -298 lines	1 comment	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

djsollen

Committed patchset #1 manually as r10664 (presubmit successful).

7 years, 4 months ago (2013-08-09 16:11:39 UTC) #4

tfarina

7 years, 4 months ago (2013-08-09 22:00:12 UTC) #5

Message was sent while issue was closed.

https://codereview.chromium.org/22450005/diff/1/gyp/public_headers.gypi
File gyp/public_headers.gypi (right):

https://codereview.chromium.org/22450005/diff/1/gyp/public_headers.gypi#newco...
gyp/public_headers.gypi:10: 'pdf/SkPDFDevice.h'
can you sort this list in ASCII alphabetical order?

Expand Messages | Collapse Messages