Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(196)

Unified Diff: chrome/common/safe_browsing/permission_report.proto

Issue 2244993002: Permission Report: Add new fields. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: update comments Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/common/safe_browsing/permission_report.proto
diff --git a/chrome/common/safe_browsing/permission_report.proto b/chrome/common/safe_browsing/permission_report.proto
index f09c5c3d403c2c81ea31481f532b0024483281f7..3bf411f31a8d7b2b7101a493add97dfe43a2c794 100644
--- a/chrome/common/safe_browsing/permission_report.proto
+++ b/chrome/common/safe_browsing/permission_report.proto
@@ -3,7 +3,7 @@
// found in the LICENSE file.
// Protocol buffer for permission reports sent to the Safe Browsing client-side
-// detection (CSD) frontends. This should stay in sync with the Safe Browsing
+// detection (CSD) frontends. This should stay in sync with the Safe Browsing
// server-side protocol buffer.
syntax = "proto2";
@@ -36,6 +36,18 @@ message PermissionReport {
// The relevant field trials enabled for this report.
repeated FieldTrial field_trials = 7;
+ // The number of dismissals on a prompt for this permission and origin prior
+ // to this report since the user last cleared their history.
+ optional int32 num_prior_dismissals = 8;
+
+ // The number of ignores of a prompt for this permission and origin prior to
+ // this report since the user last cleared their history.
+ optional int32 num_prior_ignores = 9;
+
+ // The persistence decision on a prompt. Only some experimental prompts will
+ // have this field set.
+ optional PersistDecision persisted = 10;
+
// Platform
enum PlatformType {
PLATFORM_TYPE_UNSPECIFIED = 0;
@@ -50,7 +62,7 @@ message PermissionReport {
NO_GESTURE = 2;
}
- // User Permission Actions. This enum is intentionally different with
+ // User Permission Actions. This enum is intentionally different from
// the one in src/chrome/browser/permissions/permission_uma_util.h
enum Action {
ACTION_UNSPECIFIED = 0;
@@ -85,6 +97,13 @@ message PermissionReport {
VIDEO_CAPTURE = 9;
}
+ // Whether the decision on a prompt was persisted.
+ enum PersistDecision {
+ PERSIST_DECISION_UNSPECIFIED = 0;
+ PERSISTED = 1;
+ NOT_PERSISTED = 2;
+ }
+
// Description of a field trial or experiment that the user is currently
// enrolled in. All metrics reported in this upload can potentially be
// influenced by the field trial.
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698