Chromium Code Reviews| Index: chrome/common/safe_browsing/permission_report.proto |
| diff --git a/chrome/common/safe_browsing/permission_report.proto b/chrome/common/safe_browsing/permission_report.proto |
| index f09c5c3d403c2c81ea31481f532b0024483281f7..7c405e217e1efeab29539279dbfb034999de0226 100644 |
| --- a/chrome/common/safe_browsing/permission_report.proto |
| +++ b/chrome/common/safe_browsing/permission_report.proto |
| @@ -36,6 +36,16 @@ message PermissionReport { |
| // The relevant field trials enabled for this report. |
| repeated FieldTrial field_trials = 7; |
| + // The number of dismissal on a prompt for this origin prior to this report. |
|
dominickn
2016/08/15 04:37:11
Nit: dismissal -> dismissals
Nit: "for this origi
kcarattini
2016/08/15 07:02:25
Done.
|
| + optional int32 num_prior_dismissals = 8; |
| + |
| + // The number of ignores of a prompt for this origin prior to this report. |
| + optional int32 num_prior_ignores = 9; |
| + |
| + // The persistance decision on a prompt. Only some experimental prompts will |
|
dominickn
2016/08/15 04:37:11
Nit: "persistance" -> "persistence"
kcarattini
2016/08/15 07:02:25
Done.
|
| + // have this field set. |
| + optional PersistDecision persisted = 10; |
| + |
| // Platform |
| enum PlatformType { |
| PLATFORM_TYPE_UNSPECIFIED = 0; |
| @@ -50,7 +60,7 @@ message PermissionReport { |
| NO_GESTURE = 2; |
| } |
| - // User Permission Actions. This enum is intentionally different with |
| + // User Permission Actions. This enum is intentionally different from |
| // the one in src/chrome/browser/permissions/permission_uma_util.h |
| enum Action { |
| ACTION_UNSPECIFIED = 0; |
| @@ -85,6 +95,13 @@ message PermissionReport { |
| VIDEO_CAPTURE = 9; |
| } |
| + // Whether the decision on a prompt was persisted. |
| + enum PersistDecision { |
| + PERSIST_DECISION_UNSPECIFIED = 0; |
| + PERSISTED = 1; |
| + NOT_PERSISTED = 2; |
| + } |
| + |
| // Description of a field trial or experiment that the user is currently |
| // enrolled in. All metrics reported in this upload can potentially be |
| // influenced by the field trial. |