Permission Report: Add new fields.

Permission Report: Add new fields.

Add three new fields to Permission Reports: the number of dismissals and
ignores prior to this report, and whether the decision on a prompt was persisted.

BUG=613883
Committed: https://crrev.com/75fced2336ef1b15095f9e111b411b3ef860960c
Cr-Commit-Position: refs/heads/master@{#412169}

[kcarattini, 2016-08-15 02:10:52]

kcarattini@chromium.org changed reviewers:
+ dominickn@chromium.org

[kcarattini, 2016-08-15 02:12:15]

The CQ bit was checked by kcarattini@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-08-15 02:12:27]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-15 02:53:35]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-15 02:53:36]

Dry run: This issue passed the CQ dry run.

[dominickn, 2016-08-15 04:37:11]

lgtm % nits

https://codereview.chromium.org/2244993002/diff/1/chrome/common/safe_browsing...
File chrome/common/safe_browsing/permission_report.proto (right):

https://codereview.chromium.org/2244993002/diff/1/chrome/common/safe_browsing...
chrome/common/safe_browsing/permission_report.proto:39: // The number of
dismissal on a prompt for this origin prior to this report.
Nit: dismissal -> dismissals

Nit: "for this origin" -> "for this permission for this origin"

Same for num_prior_ignores.

https://codereview.chromium.org/2244993002/diff/1/chrome/common/safe_browsing...
chrome/common/safe_browsing/permission_report.proto:45: // The persistance
decision on a prompt. Only some experimental prompts will
Nit: "persistance" -> "persistence"

[kcarattini, 2016-08-15 07:02:24]

kcarattini@chromium.org changed reviewers:
+ nparker@chromium.org

[kcarattini, 2016-08-15 07:02:25]

Thanks, Dom!

Adding Nathan as reviewer for SB approval.

https://codereview.chromium.org/2244993002/diff/1/chrome/common/safe_browsing...
File chrome/common/safe_browsing/permission_report.proto (right):

https://codereview.chromium.org/2244993002/diff/1/chrome/common/safe_browsing...
chrome/common/safe_browsing/permission_report.proto:39: // The number of
dismissal on a prompt for this origin prior to this report.
On 2016/08/15 04:37:11, dominickn wrote:
> Nit: dismissal -> dismissals
> 
> Nit: "for this origin" -> "for this permission for this origin"
> 
> Same for num_prior_ignores.

Done.

https://codereview.chromium.org/2244993002/diff/1/chrome/common/safe_browsing...
chrome/common/safe_browsing/permission_report.proto:45: // The persistance
decision on a prompt. Only some experimental prompts will
On 2016/08/15 04:37:11, dominickn wrote:
> Nit: "persistance" -> "persistence"

Done.

[Nathan Parker, 2016-08-15 18:48:49]

lgtm

https://codereview.chromium.org/2244993002/diff/40001/chrome/common/safe_brow...
File chrome/common/safe_browsing/permission_report.proto (right):

https://codereview.chromium.org/2244993002/diff/40001/chrome/common/safe_brow...
chrome/common/safe_browsing/permission_report.proto:41: optional int32
num_prior_dismissals = 8;
Please clarify in the comments: Are these counts since the last report, or since
the browser started?

[kcarattini, 2016-08-16 04:11:15]

https://codereview.chromium.org/2244993002/diff/40001/chrome/common/safe_brow...
File chrome/common/safe_browsing/permission_report.proto (right):

https://codereview.chromium.org/2244993002/diff/40001/chrome/common/safe_brow...
chrome/common/safe_browsing/permission_report.proto:41: optional int32
num_prior_dismissals = 8;
On 2016/08/15 18:48:49, Nathan Parker wrote:
> Please clarify in the comments: Are these counts since the last report, or
since
> the browser started?

Done.

[kcarattini, 2016-08-16 04:11:24]

The CQ bit was checked by kcarattini@chromium.org

[kcarattini, 2016-08-16 04:11:25]

The patchset sent to the CQ was uploaded after l-g-t-m from
dominickn@chromium.org, nparker@chromium.org
Link to the patchset: https://codereview.chromium.org/2244993002/#ps60001
(title: "update comments")

[commit-bot: I haz the power, 2016-08-16 04:11:46]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-16 05:04:24]

Committed patchset #4 (id:60001)

[commit-bot: I haz the power, 2016-08-16 05:06:34]

Description was changed from

==========
Permission Report: Add new fields.

Add three new fields to Permission Reports: the number of dismissals and
ignores prior to this report, and whether the decision on a prompt was
persisted.

BUG=613883
==========

to

==========
Permission Report: Add new fields.

Add three new fields to Permission Reports: the number of dismissals and
ignores prior to this report, and whether the decision on a prompt was
persisted.

BUG=613883

Committed: https://crrev.com/75fced2336ef1b15095f9e111b411b3ef860960c
Cr-Commit-Position: refs/heads/master@{#412169}
==========

[commit-bot: I haz the power, 2016-08-16 05:06:35]

Patchset 4 (id:??) landed as
https://crrev.com/75fced2336ef1b15095f9e111b411b3ef860960c
Cr-Commit-Position: refs/heads/master@{#412169}