Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(236)

Issue 2244993002: Permission Report: Add new fields. (Closed)

Created:
4 years, 4 months ago by kcarattini
Modified:
4 years, 4 months ago
CC:
chromium-reviews, grt+watch_chromium.org, chrome-apps-syd-reviews_chromium.org, raymes
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Permission Report: Add new fields. Add three new fields to Permission Reports: the number of dismissals and ignores prior to this report, and whether the decision on a prompt was persisted. BUG=613883 Committed: https://crrev.com/75fced2336ef1b15095f9e111b411b3ef860960c Cr-Commit-Position: refs/heads/master@{#412169}

Patch Set 1 #

Total comments: 4

Patch Set 2 : Address comments #

Patch Set 3 : Rebase #

Total comments: 2

Patch Set 4 : update comments #

Unified diffs Side-by-side diffs Delta from patch set Stats (+21 lines, -2 lines) Patch
M chrome/common/safe_browsing/permission_report.proto View 1 2 3 4 chunks +21 lines, -2 lines 0 comments Download

Dependent Patchsets:

Messages

Total messages: 18 (9 generated)
kcarattini
4 years, 4 months ago (2016-08-15 02:10:53 UTC) #2
kcarattini
4 years, 4 months ago (2016-08-15 02:11:12 UTC) #3
dominickn
lgtm % nits https://codereview.chromium.org/2244993002/diff/1/chrome/common/safe_browsing/permission_report.proto File chrome/common/safe_browsing/permission_report.proto (right): https://codereview.chromium.org/2244993002/diff/1/chrome/common/safe_browsing/permission_report.proto#newcode39 chrome/common/safe_browsing/permission_report.proto:39: // The number of dismissal on ...
4 years, 4 months ago (2016-08-15 04:37:11 UTC) #8
kcarattini
Thanks, Dom! Adding Nathan as reviewer for SB approval. https://codereview.chromium.org/2244993002/diff/1/chrome/common/safe_browsing/permission_report.proto File chrome/common/safe_browsing/permission_report.proto (right): https://codereview.chromium.org/2244993002/diff/1/chrome/common/safe_browsing/permission_report.proto#newcode39 chrome/common/safe_browsing/permission_report.proto:39: ...
4 years, 4 months ago (2016-08-15 07:02:25 UTC) #10
Nathan Parker
lgtm https://codereview.chromium.org/2244993002/diff/40001/chrome/common/safe_browsing/permission_report.proto File chrome/common/safe_browsing/permission_report.proto (right): https://codereview.chromium.org/2244993002/diff/40001/chrome/common/safe_browsing/permission_report.proto#newcode41 chrome/common/safe_browsing/permission_report.proto:41: optional int32 num_prior_dismissals = 8; Please clarify in ...
4 years, 4 months ago (2016-08-15 18:48:49 UTC) #11
kcarattini
https://codereview.chromium.org/2244993002/diff/40001/chrome/common/safe_browsing/permission_report.proto File chrome/common/safe_browsing/permission_report.proto (right): https://codereview.chromium.org/2244993002/diff/40001/chrome/common/safe_browsing/permission_report.proto#newcode41 chrome/common/safe_browsing/permission_report.proto:41: optional int32 num_prior_dismissals = 8; On 2016/08/15 18:48:49, Nathan ...
4 years, 4 months ago (2016-08-16 04:11:15 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2244993002/60001
4 years, 4 months ago (2016-08-16 04:11:46 UTC) #15
commit-bot: I haz the power
Committed patchset #4 (id:60001)
4 years, 4 months ago (2016-08-16 05:04:24 UTC) #16
commit-bot: I haz the power
4 years, 4 months ago (2016-08-16 05:06:35 UTC) #18
Message was sent while issue was closed.
Patchset 4 (id:??) landed as
https://crrev.com/75fced2336ef1b15095f9e111b411b3ef860960c
Cr-Commit-Position: refs/heads/master@{#412169}

Powered by Google App Engine
This is Rietveld 408576698