Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(57)

Unified Diff: tools/perf/page_sets/page_cycler_story.py

Issue 2244943002: Introduce PageCyclerStory and let the stories wait for onload+TTI (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: tools/perf/page_sets/page_cycler_story.py
diff --git a/tools/perf/page_sets/page_cycler_story.py b/tools/perf/page_sets/page_cycler_story.py
new file mode 100644
index 0000000000000000000000000000000000000000..5d42ac2d50fb89a29826e05f19e38e82a1af16bc
--- /dev/null
+++ b/tools/perf/page_sets/page_cycler_story.py
@@ -0,0 +1,22 @@
+# Copyright 2016 The Chromium Authors. All rights reserved.
+# Use of this source code is governed by a BSD-style license that can be
+# found in the LICENSE file.
+from telemetry.page import page
petrcermak 2016/08/15 10:49:30 ditto
kouhei (in TOK) 2016/08/22 06:09:21 Done.
+from telemetry.page import cache_temperature as cache_temperature_module
+from telemetry.page import shared_page_state
+
+_TTI_WAIT_TIME = 5
nednguyen 2016/08/15 14:00:46 Should this by 10s since TTI requires a 5s window?
kouhei (in TOK) 2016/08/22 06:09:21 Done.
+
+class PageCyclerStory(page.Page):
+
+ def __init__(self, url, page_set,
+ shared_page_state_class=shared_page_state.SharedDesktopPageState,
+ cache_temperature=cache_temperature_module.ANY):
petrcermak 2016/08/15 10:49:30 maybe pass *args and **kwargs to the super constru
+ super(PageCyclerStory, self).__init__(
+ url=url, page_set=page_set,
+ shared_page_state_class=shared_page_state_class,
+ cache_temperature=cache_temperature)
+
+ def RunPageInteractions(self, action_runner):
+ action_runner.tab.WaitForDocumentReadyStateToBeComplete()
+ action_runner.Wait(_TTI_WAIT_TIME)
« tools/perf/page_sets/intl_ko_th_vi.py ('K') | « tools/perf/page_sets/intl_ko_th_vi.py ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698