tools/perf/page_sets/intl_ar_fa_he.py - Issue 2244943002: Introduce PageCyclerStory and let the stories wait for onload+TTI

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tools/perf/page_sets/intl_ar_fa_he.py

Issue 2244943002: Introduce PageCyclerStory and let the stories wait for onload+TTI (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: tools/perf/page_sets/intl_ar_fa_he.py

diff --git a/tools/perf/page_sets/intl_ar_fa_he.py b/tools/perf/page_sets/intl_ar_fa_he.py

index cc8f597c07114531599a995c2e903f2e221d7b59..39abb4342c5f80710e56ba5a69a985e2c1324e5f 100644

--- a/tools/perf/page_sets/intl_ar_fa_he.py

+++ b/tools/perf/page_sets/intl_ar_fa_he.py

@@ -1,13 +1,13 @@

# Use of this source code is governed by a BSD-style license that can be

# found in the LICENSE file.

+from page_sets import page_cycler_story

petrcermak 2016/08/15 10:49:29 nit: Can you please add a blank line above this on

kouhei (in TOK) 2016/08/22 06:09:21 Done.

from telemetry.page import cache_temperature as cache_temperature_module

-from telemetry.page import page as page_module

from telemetry.page import shared_page_state

from telemetry import story

-class IntlArFaHePage(page_module.Page):

+class IntlArFaHePage(page_cycler_story.PageCyclerStory):

def __init__(self, url, page_set, cache_temperature=None):

super(IntlArFaHePage, self).__init__(

« no previous file with comments | « no previous file | tools/perf/page_sets/intl_es_fr_pt-BR.py » ('j') | tools/perf/page_sets/intl_es_fr_pt-BR.py » ('J')