Introduce PageCyclerStory and let the stories wait for onload+TTI

Introduce PageCyclerStory and let the stories wait for onload+TTI

BUG=626274
Committed: https://crrev.com/5cbfbf15751cfaff33008bd0dd54699b7791158b
Cr-Commit-Position: refs/heads/master@{#413414}

[kouhei (in TOK), 2016-08-13 08:57:37]

kouhei@chromium.org changed reviewers:
+ nednguyen@google.com, petrcermak@chromium.org

[kouhei (in TOK), 2016-08-13 08:57:49]

The CQ bit was checked by kouhei@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-08-13 08:57:52]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-13 09:46:44]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-13 09:46:45]

Dry run: This issue passed the CQ dry run.

[petrcermak, 2016-08-15 10:48:20]

Description was changed from

==========
Introduce PageCyclerStory and let the stories wait for onload+TTI

BUG=chromium:#626274
==========

to

==========
Introduce PageCyclerStory and let the stories wait for onload+TTI

BUG=626274
==========

[petrcermak, 2016-08-15 10:49:30]

LGTM with a couple of nits. However, please wait for Ned's approval. I am only
an owner for System-Health related stuff.

I took the liberty of editing the BUG=... line so that Rietveld understands it
(and turns it into a hyperlink).

Thanks,
Petr

https://codereview.chromium.org/2244943002/diff/1/tools/perf/page_sets/intl_a...
File tools/perf/page_sets/intl_ar_fa_he.py (right):

https://codereview.chromium.org/2244943002/diff/1/tools/perf/page_sets/intl_a...
tools/perf/page_sets/intl_ar_fa_he.py:4: from page_sets import page_cycler_story
nit: Can you please add a blank line above this one

https://codereview.chromium.org/2244943002/diff/1/tools/perf/page_sets/intl_e...
File tools/perf/page_sets/intl_es_fr_pt-BR.py (right):

https://codereview.chromium.org/2244943002/diff/1/tools/perf/page_sets/intl_e...
tools/perf/page_sets/intl_es_fr_pt-BR.py:4: from page_sets import
page_cycler_story
ditto

https://codereview.chromium.org/2244943002/diff/1/tools/perf/page_sets/intl_h...
File tools/perf/page_sets/intl_hi_ru.py (right):

https://codereview.chromium.org/2244943002/diff/1/tools/perf/page_sets/intl_h...
tools/perf/page_sets/intl_hi_ru.py:4: from page_sets import page_cycler_story
ditto

https://codereview.chromium.org/2244943002/diff/1/tools/perf/page_sets/intl_j...
File tools/perf/page_sets/intl_ja_zh.py (right):

https://codereview.chromium.org/2244943002/diff/1/tools/perf/page_sets/intl_j...
tools/perf/page_sets/intl_ja_zh.py:4: from page_sets import page_cycler_story
ditto

https://codereview.chromium.org/2244943002/diff/1/tools/perf/page_sets/intl_k...
File tools/perf/page_sets/intl_ko_th_vi.py (right):

https://codereview.chromium.org/2244943002/diff/1/tools/perf/page_sets/intl_k...
tools/perf/page_sets/intl_ko_th_vi.py:4: from page_sets import page_cycler_story
ditto

https://codereview.chromium.org/2244943002/diff/1/tools/perf/page_sets/page_c...
File tools/perf/page_sets/page_cycler_story.py (right):

https://codereview.chromium.org/2244943002/diff/1/tools/perf/page_sets/page_c...
tools/perf/page_sets/page_cycler_story.py:4: from telemetry.page import page
ditto

https://codereview.chromium.org/2244943002/diff/1/tools/perf/page_sets/page_c...
tools/perf/page_sets/page_cycler_story.py:14:
cache_temperature=cache_temperature_module.ANY):
maybe pass *args and **kwargs to the super constructor?

[nednguyen, 2016-08-15 14:00:46]

lgtm

https://codereview.chromium.org/2244943002/diff/1/tools/perf/page_sets/page_c...
File tools/perf/page_sets/page_cycler_story.py (right):

https://codereview.chromium.org/2244943002/diff/1/tools/perf/page_sets/page_c...
tools/perf/page_sets/page_cycler_story.py:8: _TTI_WAIT_TIME = 5
Should this by 10s since TTI requires a 5s window?

[kouhei (in TOK), 2016-08-22 06:09:21]

https://codereview.chromium.org/2244943002/diff/1/tools/perf/page_sets/intl_a...
File tools/perf/page_sets/intl_ar_fa_he.py (right):

https://codereview.chromium.org/2244943002/diff/1/tools/perf/page_sets/intl_a...
tools/perf/page_sets/intl_ar_fa_he.py:4: from page_sets import page_cycler_story
On 2016/08/15 10:49:29, petrcermak wrote:
> nit: Can you please add a blank line above this one

Done.

https://codereview.chromium.org/2244943002/diff/1/tools/perf/page_sets/intl_e...
File tools/perf/page_sets/intl_es_fr_pt-BR.py (right):

https://codereview.chromium.org/2244943002/diff/1/tools/perf/page_sets/intl_e...
tools/perf/page_sets/intl_es_fr_pt-BR.py:4: from page_sets import
page_cycler_story
On 2016/08/15 10:49:29, petrcermak wrote:
> ditto

Done.

https://codereview.chromium.org/2244943002/diff/1/tools/perf/page_sets/intl_h...
File tools/perf/page_sets/intl_hi_ru.py (right):

https://codereview.chromium.org/2244943002/diff/1/tools/perf/page_sets/intl_h...
tools/perf/page_sets/intl_hi_ru.py:4: from page_sets import page_cycler_story
On 2016/08/15 10:49:29, petrcermak wrote:
> ditto

Done.

https://codereview.chromium.org/2244943002/diff/1/tools/perf/page_sets/intl_j...
File tools/perf/page_sets/intl_ja_zh.py (right):

https://codereview.chromium.org/2244943002/diff/1/tools/perf/page_sets/intl_j...
tools/perf/page_sets/intl_ja_zh.py:4: from page_sets import page_cycler_story
On 2016/08/15 10:49:30, petrcermak wrote:
> ditto

Done.

https://codereview.chromium.org/2244943002/diff/1/tools/perf/page_sets/intl_k...
File tools/perf/page_sets/intl_ko_th_vi.py (right):

https://codereview.chromium.org/2244943002/diff/1/tools/perf/page_sets/intl_k...
tools/perf/page_sets/intl_ko_th_vi.py:4: from page_sets import page_cycler_story
On 2016/08/15 10:49:30, petrcermak wrote:
> ditto

Done.

https://codereview.chromium.org/2244943002/diff/1/tools/perf/page_sets/page_c...
File tools/perf/page_sets/page_cycler_story.py (right):

https://codereview.chromium.org/2244943002/diff/1/tools/perf/page_sets/page_c...
tools/perf/page_sets/page_cycler_story.py:4: from telemetry.page import page
On 2016/08/15 10:49:30, petrcermak wrote:
> ditto

Done.

https://codereview.chromium.org/2244943002/diff/1/tools/perf/page_sets/page_c...
tools/perf/page_sets/page_cycler_story.py:8: _TTI_WAIT_TIME = 5
On 2016/08/15 14:00:46, nednguyen wrote:
> Should this by 10s since TTI requires a 5s window?

Done.

[kouhei (in TOK), 2016-08-22 06:09:26]

The CQ bit was checked by kouhei@chromium.org

[kouhei (in TOK), 2016-08-22 06:09:27]

The patchset sent to the CQ was uploaded after l-g-t-m from
nednguyen@google.com, petrcermak@chromium.org
Link to the patchset: https://codereview.chromium.org/2244943002/#ps20001
(title: "blank lines / 10sec / kwargs")

[commit-bot: I haz the power, 2016-08-22 06:09:41]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-22 07:09:43]

Description was changed from

==========
Introduce PageCyclerStory and let the stories wait for onload+TTI

BUG=626274
==========

to

==========
Introduce PageCyclerStory and let the stories wait for onload+TTI

BUG=626274
==========

[commit-bot: I haz the power, 2016-08-22 07:09:44]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-08-22 07:10:56]

Description was changed from

==========
Introduce PageCyclerStory and let the stories wait for onload+TTI

BUG=626274
==========

to

==========
Introduce PageCyclerStory and let the stories wait for onload+TTI

BUG=626274

Committed: https://crrev.com/5cbfbf15751cfaff33008bd0dd54699b7791158b
Cr-Commit-Position: refs/heads/master@{#413414}
==========

[commit-bot: I haz the power, 2016-08-22 07:10:56]

Patchset 2 (id:??) landed as
https://crrev.com/5cbfbf15751cfaff33008bd0dd54699b7791158b
Cr-Commit-Position: refs/heads/master@{#413414}