content/renderer/render_frame_impl.h - Issue 2244913002: Remove content::NotificationPermissionDispatcher.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/renderer/render_frame_impl.h

Issue 2244913002: Remove content::NotificationPermissionDispatcher. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@permissions_typemaps

Patch Set: Move service connection to NotificationManager. Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « content/renderer/notification_permission_dispatcher.cc ('k') | content/renderer/render_frame_impl.cc » ('j') | third_party/WebKit/Source/modules/notifications/Notification.cpp » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/renderer/render_frame_impl.h

diff --git a/content/renderer/render_frame_impl.h b/content/renderer/render_frame_impl.h

index a2b0c2ef5ffd2e0b4847c8f682f8e954dd671a0f..0182154103b31c3c200a94a5a40bf1d0fbd96076 100644

--- a/content/renderer/render_frame_impl.h

+++ b/content/renderer/render_frame_impl.h

@@ -133,7 +133,6 @@ class MediaStreamRendererFactory;

class MediaPermissionDispatcher;

class MidiDispatcher;

class NavigationState;

-class NotificationPermissionDispatcher;

class PageState;

class PepperPluginInstanceImpl;

class PresentationDispatcher;

@@ -545,9 +544,6 @@ class CONTENT_EXPORT RenderFrameImpl

void didChangeThemeColor() override;

void dispatchLoad() override;

blink::WebEffectiveConnectionType getEffectiveConnectionType() override;

- void requestNotificationPermission(

- const blink::WebSecurityOrigin& origin,

- blink::WebNotificationPermissionCallback* callback) override;

void didChangeSelection(bool is_empty_selection) override;

blink::WebColorChooser* createColorChooser(

blink::WebColorChooserClient* client,

@@ -1145,9 +1141,6 @@ class CONTENT_EXPORT RenderFrameImpl

// along with the RenderFrame automatically. This is why we just store weak

// references.

- // Dispatches permission requests for Web Notifications.

- NotificationPermissionDispatcher* notification_permission_dispatcher_;

// Destroyed via the RenderFrameObserver::OnDestruct() mechanism.

UserMediaClientImpl* web_user_media_client_;