third_party/WebKit/Source/core/layout/compositing/CompositedLayerMapping.cpp - Issue 2244873002: Fix PaintPropertyTreeBuilder for root layer scrolling.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/layout/compositing/CompositedLayerMapping.cpp

Issue 2244873002: Fix PaintPropertyTreeBuilder for root layer scrolling. (Closed) Base URL: https://chromium.googlesource.com/chromium/src@rls-enable

Patch Set: Fix test expectation for rootClip Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: third_party/WebKit/Source/core/layout/compositing/CompositedLayerMapping.cpp

diff --git a/third_party/WebKit/Source/core/layout/compositing/CompositedLayerMapping.cpp b/third_party/WebKit/Source/core/layout/compositing/CompositedLayerMapping.cpp

index 6248097b19031e13208183b785a026fa7d0538de..c070f17b691aaa55202e27bd01b0c065aeb2c101 100644

--- a/third_party/WebKit/Source/core/layout/compositing/CompositedLayerMapping.cpp

+++ b/third_party/WebKit/Source/core/layout/compositing/CompositedLayerMapping.cpp

@@ -1136,7 +1136,9 @@ void CompositedLayerMapping::updateInternalHierarchy()

// Now constructing the subtree for the overflow controls.

bottomLayer = m_graphicsLayer.get();

- if (m_isMainFrameLayoutViewLayer)

+ // TODO(pdr): Ensure painting uses the correct GraphicsLayer when root layer scrolls is enabled.

+ // crbug.com/638719

+ if (m_isMainFrameLayoutViewLayer && !RuntimeEnabledFeatures::slimmingPaintV2Enabled())

bottomLayer = layoutObject()->frame()->page()->frameHost().visualViewport().containerLayer();

updateBottomLayer(m_overflowControlsAncestorClippingLayer.get());

updateBottomLayer(m_overflowControlsHostLayer.get());

« no previous file with comments | « no previous file | third_party/WebKit/Source/core/paint/PaintPropertyTreeBuilder.h » ('j') | no next file with comments »